IFF_BROADCAST and dscape

IFF_BROADCAST and dscape

[Jon Smirl]

Dscape doesn't appear to be setting IFF_BROADCAST. I have an existing
app that is refusing to load since it wants that flag. Grepping the
dscape source doesn't show IFF_BROADCAST.

zd1211 on Intel sets it:
eth1      Link encap:Ethernet  HWaddr 00:02:72:53:E3:A6
          UP BROADCAST MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 b)  TX bytes:0 (0.0 b)

rt2500usb on dscape doesn't
wlan0     Link encap:Ethernet  HWaddr 00:15:E9:2D:76:57
          UP RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:0 (0.0 b)  TX bytes:0 (0.0 b)

-- 
Jon Smirl
jonsmirl@gmail.com

Re: IFF_BROADCAST and dscape

[Jon Smirl]

On 2/6/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> Dscape doesn't appear to be setting IFF_BROADCAST. I have an existing
> app that is refusing to load since it wants that flag. Grepping the
> dscape source doesn't show IFF_BROADCAST.

This appears to fix the problem, but I'm not 100% if it is the correct fix.

Index: ieee80211_iface.c
===================================================================
RCS file: /cvsroot/rt2400/source/rt2x00/ieee80211/ieee80211_iface.c,v
retrieving revision 1.21
diff -r1.21 ieee80211_iface.c
78c78
<       ndev->flags = dev->flags & IFF_MULTICAST;
---
>       ndev->flags = dev->flags & (IFF_MULTICAST | IFF_BROADCAST);



-- 
Jon Smirl
jonsmirl@gmail.com

[PATCH] d80211: use default flags on virtual interfaces

[Michael Wu]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

d80211: use default flags on virtual interfaces

There is no need to set dev->flags on virtual interfaces
during registration.

Signed-off-by: Michael Wu <flamingice@sourmilk.net>
---

 net/d80211/ieee80211_iface.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/d80211/ieee80211_iface.c b/net/d80211/ieee80211_iface.c
index 3b2d259..342ad2a 100644
--- a/net/d80211/ieee80211_iface.c
+++ b/net/d80211/ieee80211_iface.c
@@ -75,7 +75,6 @@ int ieee80211_if_add(struct net_device *
 	ndev->irq = dev->irq;
 	ndev->mem_start = dev->mem_start;
 	ndev->mem_end = dev->mem_end;
-	ndev->flags = dev->flags & IFF_MULTICAST;
 	SET_NETDEV_DEV(ndev, local->hw.dev);
 
 	sdata = IEEE80211_DEV_TO_SUB_IF(ndev);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] d80211: use default flags on virtual interfaces

[Jiri Benc]

On Thu, 8 Feb 2007 14:01:35 -0500, Michael Wu wrote:
> There is no need to set dev->flags on virtual interfaces
> during registration.

Applied to my tree, thanks to both Jon and Michael for fixing this.

 Jiri

-- 
Jiri Benc
SUSE Labs