All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: James Simmons <jsimmons@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Mackerras <paulus@samba.org>,
	Linux Frame Buffer Device Development
	<linux-fbdev-devel@lists.sourceforge.net>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/10] ps3: AV Settings Driver
Date: Thu, 8 Feb 2007 21:30:14 +0100	[thread overview]
Message-ID: <20070208203014.GB2579@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0702081458190.19437@pademelon.sonytel.be>

On Thu, Feb 08, 2007 at 02:58:31PM +0100, Geert Uytterhoeven wrote:
> Add the PS3 AV Settings Driver.
> 
> The AV Settings driver is used to control Audio and Video settings.
> It communicates with the policy manager through the virtual uart.

please don't use kernel_thread for new code, but rather kthread_create/
ktread_run.  And check the possible errors it can return :)

Using the kthread infrastructure also means you'll have to redo your
synchronisation scheme as it doesn't work very well with this use
of semaphores.  But that's a good thing as these useages are not
easily parseable for most kernel hackers despite beeing tought in
OS101 :)


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: James Simmons <jsimmons@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Mackerras <paulus@samba.org>,
	Linux Frame Buffer Device Development
	<linux-fbdev-devel@lists.sourceforge.net>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/10] ps3: AV Settings Driver
Date: Thu, 8 Feb 2007 21:30:14 +0100	[thread overview]
Message-ID: <20070208203014.GB2579@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0702081458190.19437@pademelon.sonytel.be>

On Thu, Feb 08, 2007 at 02:58:31PM +0100, Geert Uytterhoeven wrote:
> Add the PS3 AV Settings Driver.
> 
> The AV Settings driver is used to control Audio and Video settings.
> It communicates with the policy manager through the virtual uart.

please don't use kernel_thread for new code, but rather kthread_create/
ktread_run.  And check the possible errors it can return :)

Using the kthread infrastructure also means you'll have to redo your
synchronisation scheme as it doesn't work very well with this use
of semaphores.  But that's a good thing as these useages are not
easily parseable for most kernel hackers despite beeing tought in
OS101 :)

  reply	other threads:[~2007-02-08 20:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 13:56 [PATCH 0/10] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
2007-02-08 13:56 ` Geert Uytterhoeven
2007-02-08 13:58 ` [PATCH 1/10] ps3: Add shutdown to virtual uart port driver framework Geert Uytterhoeven
2007-02-08 13:58   ` Geert Uytterhoeven
2007-02-08 13:58 ` [PATCH 2/10] ps3: AV Settings Driver Geert Uytterhoeven
2007-02-08 13:58   ` Geert Uytterhoeven
2007-02-08 20:30   ` Christoph Hellwig [this message]
2007-02-08 20:30     ` Christoph Hellwig
2007-02-09  9:17     ` Andrew Morton
2007-02-09  9:17       ` Andrew Morton
2007-02-08 13:58 ` [PATCH 3/10] fbdev modedb: allow refresh rates for named video modes Geert Uytterhoeven
2007-02-08 13:58   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 4/10] fbdev modedb: make more pointer parameters const Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 5/10] fb_videomode_to_var: reset virtual screen parameters Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 6/10] ps3: Preallocate bootmem memory for ps3fb Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 7/10] ps3: Virtual Frame Buffer Driver Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 8/10] ps3: disable display flipping during mode changes Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 13:59 ` [PATCH 9/10] ps3: cleanup ps3fb before clearing HPTE Geert Uytterhoeven
2007-02-08 13:59   ` Geert Uytterhoeven
2007-02-08 14:00 ` [PATCH 10/10] ps3: ps3av/fb defconfig updates Geert Uytterhoeven
2007-02-08 14:00   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208203014.GB2579@lst.de \
    --to=hch@lst.de \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.