All of lore.kernel.org
 help / color / mirror / Atom feed
* - minimize-lockdep_on-off-side-effect.patch removed from -mm tree
@ 2007-02-08 23:32 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-02-08 23:32 UTC (permalink / raw)
  To: compudj, mathieu.desnoyers, mingo, mm-commits


The patch titled
     minimize lockdep_on/off side-effect
has been removed from the -mm tree.  Its filename was
     minimize-lockdep_on-off-side-effect.patch

This patch was dropped because it was folded into order-of-lockdep-off-on-in-vprintk-should-be-changed.patch

------------------------------------------------------
Subject: minimize lockdep_on/off side-effect
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>

Minimize lockdep_on/off side-effect on irq tracing in vprintk by using
raw_local_irq_save/restore _around_ lockdep_off/on().

It has the advantage of not losing the IRQ events coming between the lockdep
disabling and the irq disabling.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 kernel/printk.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN kernel/printk.c~minimize-lockdep_on-off-side-effect kernel/printk.c
--- a/kernel/printk.c~minimize-lockdep_on-off-side-effect
+++ a/kernel/printk.c
@@ -529,8 +529,8 @@ asmlinkage int vprintk(const char *fmt, 
 		zap_locks();
 
 	/* This stops the holder of console_sem just where we want him */
+	raw_local_irq_save(flags);
 	lockdep_off();
-	local_irq_save(flags);
 	spin_lock(&logbuf_lock);
 	printk_cpu = smp_processor_id();
 
@@ -617,8 +617,8 @@ asmlinkage int vprintk(const char *fmt, 
 			console_locked = 0;
 			up(&console_sem);
 		}
-		local_irq_restore(flags);
 		lockdep_on();
+		raw_local_irq_restore(flags);
 	} else {
 		/*
 		 * Someone else owns the drivers.  We drop the spinlock, which
@@ -627,8 +627,8 @@ asmlinkage int vprintk(const char *fmt, 
 		 */
 		printk_cpu = UINT_MAX;
 		spin_unlock(&logbuf_lock);
-		local_irq_restore(flags);
 		lockdep_on();
+		raw_local_irq_restore(flags);
 	}
 
 	preempt_enable();
_

Patches currently in -mm which might be from compudj@krystal.dyndns.org are

origin.patch
order-of-lockdep-off-on-in-vprintk-should-be-changed.patch
minimize-lockdep_on-off-side-effect.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-08 23:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08 23:32 - minimize-lockdep_on-off-side-effect.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.