* [PATCH] sunrpc: remove dead variable 'rpciod_running'
@ 2007-02-09 20:06 Christoph Hellwig
2007-02-10 0:03 ` Chuck Lever
2007-05-13 15:10 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Christoph Hellwig @ 2007-02-09 20:06 UTC (permalink / raw)
To: chuck.lever; +Cc: nfs
rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
works we don't get a warning for it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/net/sunrpc/sched.c
===================================================================
--- linux-2.6.orig/net/sunrpc/sched.c 2007-02-06 15:55:43.000000000 +0100
+++ linux-2.6/net/sunrpc/sched.c 2007-02-06 15:55:45.000000000 +0100
@@ -973,8 +973,6 @@
spin_unlock(&rpc_sched_lock);
}
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
static void rpciod_killall(void)
{
unsigned long flags;
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'
2007-02-09 20:06 [PATCH] sunrpc: remove dead variable 'rpciod_running' Christoph Hellwig
@ 2007-02-10 0:03 ` Chuck Lever
2007-05-13 15:10 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Chuck Lever @ 2007-02-10 0:03 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: nfs
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
At a glance, this looks reasonable.
Christoph Hellwig wrote:
> rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> works we don't get a warning for it.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/net/sunrpc/sched.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/sched.c 2007-02-06 15:55:43.000000000 +0100
> +++ linux-2.6/net/sunrpc/sched.c 2007-02-06 15:55:45.000000000 +0100
> @@ -973,8 +973,6 @@
> spin_unlock(&rpc_sched_lock);
> }
>
> -static DECLARE_MUTEX_LOCKED(rpciod_running);
> -
> static void rpciod_killall(void)
> {
> unsigned long flags;
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 265 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture Linux Projects Group
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
[-- Attachment #3: Type: text/plain, Size: 374 bytes --]
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
[-- Attachment #4: Type: text/plain, Size: 140 bytes --]
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'
2007-02-09 20:06 [PATCH] sunrpc: remove dead variable 'rpciod_running' Christoph Hellwig
2007-02-10 0:03 ` Chuck Lever
@ 2007-05-13 15:10 ` Christoph Hellwig
2007-05-13 19:51 ` Trond Myklebust
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2007-05-13 15:10 UTC (permalink / raw)
To: chuck.lever; +Cc: nfs
On Fri, Feb 09, 2007 at 08:06:49PM +0000, Christoph Hellwig wrote:
> rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> works we don't get a warning for it.
Looks like this one is still not in. Any chance to send it to Linus
in this merge cycle?
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/net/sunrpc/sched.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/sched.c 2007-02-06 15:55:43.000000000 +0100
> +++ linux-2.6/net/sunrpc/sched.c 2007-02-06 15:55:45.000000000 +0100
> @@ -973,8 +973,6 @@
> spin_unlock(&rpc_sched_lock);
> }
>
> -static DECLARE_MUTEX_LOCKED(rpciod_running);
> -
> static void rpciod_killall(void)
> {
> unsigned long flags;
---end quoted text---
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'
2007-05-13 15:10 ` Christoph Hellwig
@ 2007-05-13 19:51 ` Trond Myklebust
0 siblings, 0 replies; 4+ messages in thread
From: Trond Myklebust @ 2007-05-13 19:51 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: nfs
On Sun, 2007-05-13 at 16:10 +0100, Christoph Hellwig wrote:
> On Fri, Feb 09, 2007 at 08:06:49PM +0000, Christoph Hellwig wrote:
> > rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> > works we don't get a warning for it.
>
> Looks like this one is still not in. Any chance to send it to Linus
> in this merge cycle?
Oops. My bad. I must have dropped it by accident... I'll send it in.
Cheers
Trond
>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Index: linux-2.6/net/sunrpc/sched.c
> > ===================================================================
> > --- linux-2.6.orig/net/sunrpc/sched.c 2007-02-06 15:55:43.000000000 +0100
> > +++ linux-2.6/net/sunrpc/sched.c 2007-02-06 15:55:45.000000000 +0100
> > @@ -973,8 +973,6 @@
> > spin_unlock(&rpc_sched_lock);
> > }
> >
> > -static DECLARE_MUTEX_LOCKED(rpciod_running);
> > -
> > static void rpciod_killall(void)
> > {
> > unsigned long flags;
> ---end quoted text---
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> NFS maillist - NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-13 19:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-09 20:06 [PATCH] sunrpc: remove dead variable 'rpciod_running' Christoph Hellwig
2007-02-10 0:03 ` Chuck Lever
2007-05-13 15:10 ` Christoph Hellwig
2007-05-13 19:51 ` Trond Myklebust
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.