All of lore.kernel.org
 help / color / mirror / Atom feed
* e2fsprogs coverity patch <cid-14.diff>
@ 2007-02-10  2:11 Brian D. Behlendorf
  0 siblings, 0 replies; only message in thread
From: Brian D. Behlendorf @ 2007-02-10  2:11 UTC (permalink / raw)
  To: tytso; +Cc: linux-ext4, adilger, behlendorf1, wartens2

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see 
if it would identify any significant bugs.  The analysis
turned up 38 mostly minor issues which are enumerated here
with patches.  We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Thanks,
Brian Behlendorf <behlendorf1@llnl.gov>, and
Herb Wartens <wartens2@llnl.gov>

-----------------------------------------------------------------------------
Coverity ID: 14: Resource Leak

The profile must be freed early if subsequent memory allocations
fail for 'expanded_filename'.  

Index: e2fsprogs+chaos/e2fsck/profile.c
===================================================================
--- e2fsprogs+chaos.orig/e2fsck/profile.c
+++ e2fsprogs+chaos/e2fsck/profile.c
@@ -414,13 +414,16 @@ errcode_t profile_open_file(const char *
 			len += strlen(home_env);
 	}
 	expanded_filename = malloc(len);
-	if (expanded_filename == 0)
+	if (!expanded_filename) {
+	    profile_free_file(prf);
 	    return errno;
+	}
 	if (home_env) {
 	    strcpy(expanded_filename, home_env);
 	    strcat(expanded_filename, filespec+1);
-	} else
+	} else {
 	    memcpy(expanded_filename, filespec, len);
+	}
 
 	prf->filespec = expanded_filename;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-10  2:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-10  2:11 e2fsprogs coverity patch <cid-14.diff> Brian D. Behlendorf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.