[PATCH] [NETDEV] [000] dmfe : fix bugs and add features

[PATCH] [NETDEV] [000] dmfe : fix bugs and add features

[Levitsky Maxim]

Hello,

Before some time I decided to fix suspend/resume on my Davicom network card.
During development I also fixed couple of bugs and added support for link detection and WOL
Note : 2.6.20 already has support for link detection , but it is broken when card has external PHY
, like mine.

So here it goes:

[PATCH] [NET] [001] dmfe : trivial/spelling fixes
[PATCH] [NET] [002] dmfe : Fix possible oops
[PATCH] [NET] [003] dmfe : fix link detection
[PATCH] [NET] [004] dmfe : Add suspend/resume support
[PATCH] [NET] [005] dmfe : Add support for wake-on-lan

        Maxim Levitsky


 
____________________________________________________________________________________
Finding fabulous fares is fun.  
Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains.
http://farechase.yahoo.com/promo-generic-14795097

Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features

[Jeff Garzik]

Levitsky Maxim wrote:
> Hello,
> 
> Before some time I decided to fix suspend/resume on my Davicom network card.
> During development I also fixed couple of bugs and added support for link detection and WOL
> Note : 2.6.20 already has support for link detection , but it is broken when card has external PHY
> , like mine.
> 
> So here it goes:
> 
> [PATCH] [NET] [001] dmfe : trivial/spelling fixes
> [PATCH] [NET] [002] dmfe : Fix possible oops
> [PATCH] [NET] [003] dmfe : fix link detection
> [PATCH] [NET] [004] dmfe : Add suspend/resume support
> [PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> 
>         Maxim Levitsky
> 
> 
>  
> ____________________________________________________________________________________
> Finding fabulous fares is fun.  
> Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains.
> http://farechase.yahoo.com/promo-generic-14795097
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
What about the above report?

I would rather fix this first, before applying more patches on top of a 
problematic patch...

> Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: 
> support basic carrier detection) breaks networking on my Davicom DM9009. 
> ethtool always reports there is no link.  tcpdump shows incoming 
> packets, but TX is disabled.  Reverting the above patch fixes the 
> problem.

Regards,

	Jeff

Re: [PATCH] [000] dmfe : fix bugs and add features

[Jeff Garzik]

Levitsky Maxim wrote:
> Hello,
> 
> Before some time I decided to fix suspend/resume on my Davicom network card.
> During development I also fixed couple of bugs and added support for link detection and WOL
> Note : 2.6.20 already has support for link detection , but it is broken when card has external PHY
> , like mine.
> 
> So here it goes:
> 
> [PATCH] [NET] [001] dmfe : trivial/spelling fixes
> [PATCH] [NET] [002] dmfe : Fix possible oops
> [PATCH] [NET] [003] dmfe : fix link detection
> [PATCH] [NET] [004] dmfe : Add suspend/resume support
> [PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> 
>         Maxim Levitsky
> 
> 
>  
> ____________________________________________________________________________________
> Finding fabulous fares is fun.  
> Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains.
> http://farechase.yahoo.com/promo-generic-14795097
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
What about the above report?

I would rather fix this first, before applying more patches on top of a 
problematic patch...

> Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: 
> support basic carrier detection) breaks networking on my Davicom DM9009. 
> ethtool always reports there is no link.  tcpdump shows incoming 
> packets, but TX is disabled.  Reverting the above patch fixes the 
> problem.

Regards,

	Jeff

Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features

[Samuel Thibault]

Hi,

Jeff Garzik, le Fri 09 Feb 2007 16:15:26 -0500, a écrit :
> Levitsky Maxim wrote:
> >Before some time I decided to fix suspend/resume on my Davicom
> >network card.  During development I also fixed couple of bugs and
> >added support for link detection and WOL Note : 2.6.20 already has
> >support for link detection , but it is broken when card has external
> >PHY, like mine.
> >
> >So here it goes:
> >
> >[PATCH] [NET] [001] dmfe : trivial/spelling fixes
> >[PATCH] [NET] [002] dmfe : Fix possible oops
> >[PATCH] [NET] [003] dmfe : fix link detection
> >[PATCH] [NET] [004] dmfe : Add suspend/resume support
> >[PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> 
> >Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: 
> >support basic carrier detection) breaks networking on my Davicom DM9009. 
> >ethtool always reports there is no link.  tcpdump shows incoming 
> >packets, but TX is disabled.  Reverting the above patch fixes the 
> >problem.
> 
> What about the above report?
> 
> I would rather fix this first, before applying more patches on top of a 
> problematic patch...

My patch wasn't implementing anything actually: it was just making the
existing-since-long link detection code available in ethtools.

Samuel

Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features

[Maxim]

On Friday 09 February 2007 23:15:26 Jeff Garzik wrote:
> Levitsky Maxim wrote:
> > Hello,
> >
> > Before some time I decided to fix suspend/resume on my Davicom network
> > card. During development I also fixed couple of bugs and added support
> > for link detection and WOL Note : 2.6.20 already has support for link
> > detection , but it is broken when card has external PHY , like mine.
> >
> > So here it goes:
> >
> > [PATCH] [NET] [001] dmfe : trivial/spelling fixes
> > [PATCH] [NET] [002] dmfe : Fix possible oops
> > [PATCH] [NET] [003] dmfe : fix link detection
> > [PATCH] [NET] [004] dmfe : Add suspend/resume support
> > [PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> >
> >         Maxim Levitsky
> >
> >
> >
> > _________________________________________________________________________
> >___________ Finding fabulous fares is fun.
> > Let Yahoo! FareChase search your favorite travel sites to find flight and
> > hotel bargains. http://farechase.yahoo.com/promo-generic-14795097
> > -
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> What about the above report?
>
> I would rather fix this first, before applying more patches on top of a
> problematic patch...
>
> > Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe:
> > support basic carrier detection) breaks networking on my Davicom DM9009.
> > ethtool always reports there is no link.  tcpdump shows incoming
> > packets, but TX is disabled.  Reverting the above patch fixes the
> > problem.
>
> Regards,
>
> 	Jeff
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Hello,

I agree , I will redo all patches with above commit reverted

Regards , Maxim Levitsky

PS: my mailbox is now maximlevitsky@gmail.com , I took it to use SMTP , 
because it less likely to corrupt patches

Re: [PATCH] [000] dmfe : fix bugs and add features

[Maxim]

On Friday 09 February 2007 23:15:26 Jeff Garzik wrote:
> Levitsky Maxim wrote:
> > Hello,
> >
> > Before some time I decided to fix suspend/resume on my Davicom network
> > card. During development I also fixed couple of bugs and added support
> > for link detection and WOL Note : 2.6.20 already has support for link
> > detection , but it is broken when card has external PHY , like mine.
> >
> > So here it goes:
> >
> > [PATCH] [NET] [001] dmfe : trivial/spelling fixes
> > [PATCH] [NET] [002] dmfe : Fix possible oops
> > [PATCH] [NET] [003] dmfe : fix link detection
> > [PATCH] [NET] [004] dmfe : Add suspend/resume support
> > [PATCH] [NET] [005] dmfe : Add support for wake-on-lan
> >
> >         Maxim Levitsky
> >
> >
> >
> > _________________________________________________________________________
> >___________ Finding fabulous fares is fun.
> > Let Yahoo! FareChase search your favorite travel sites to find flight and
> > hotel bargains. http://farechase.yahoo.com/promo-generic-14795097
> > -
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> What about the above report?
>
> I would rather fix this first, before applying more patches on top of a
> problematic patch...
>
> > Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe:
> > support basic carrier detection) breaks networking on my Davicom DM9009.
> > ethtool always reports there is no link.  tcpdump shows incoming
> > packets, but TX is disabled.  Reverting the above patch fixes the
> > problem.
>
> Regards,
>
> 	Jeff
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Hello,

I agree , I will redo all patches with above commit reverted

Regards , Maxim Levitsky

PS: my mailbox is now maximlevitsky@gmail.com , I took it to use SMTP , 
because it less likely to corrupt patches