All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
	Tejun Heo <htejun@gmail.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch] linux/io.h: forward declare struct pci_dev
Date: Sun, 11 Feb 2007 08:21:59 +0000	[thread overview]
Message-ID: <20070211082159.GT10050@ftp.linux.org.uk> (raw)
In-Reply-To: <20070211071047.GA3847@infradead.org>

On Sun, Feb 11, 2007 at 07:10:47AM +0000, Christoph Hellwig wrote:
> On Sun, Feb 11, 2007 at 06:34:31AM +0000, Al Viro wrote:
> > +config NO_IOPORT
> > +	bool
> > +	default n
> 
> please make this IOPORT.  config symbols with an implicit negation
> are quite horrible for the brain to understand.

Take a look at lib/Kconfig.  And see HAS_IOPORT there.

The reason for doing it that way: majority of targets has that stuff
already.  Even more should have it eventually.  IOW, the default should
be positive.  Modified in arch/*/Kconfig of targets where it doesn't
work.  Which is exactly what's done here.

  reply	other threads:[~2007-02-11  8:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 11:45 [patch] linux/io.h: forward declare struct pci_dev Heiko Carstens
2007-02-11  3:49 ` Christoph Hellwig
2007-02-11  6:26   ` Tejun Heo
2007-02-11  6:34     ` Al Viro
2007-02-11  6:46       ` Tejun Heo
2007-02-11  6:55       ` Randy Dunlap
2007-02-11  7:10       ` Christoph Hellwig
2007-02-11  8:21         ` Al Viro [this message]
2007-02-11 15:09       ` Jeff Garzik
2007-02-11 15:31       ` Heiko Carstens
2007-02-11 15:41         ` [PATCH] sort the devres mess out Al Viro
2007-02-11 15:49           ` Jeff Garzik
2007-02-11 22:16             ` Roland Dreier
2007-02-12  5:30               ` [PATCH] ia64: Fix noncoherent DMA API so devres builds Roland Dreier
2007-02-12 21:06                 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070211082159.GT10050@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.