All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 3/16] [powerpc] Use udbg_early_init() on ppc32
Date: Tue, 13 Feb 2007 17:10:24 +1100 (EST)	[thread overview]
Message-ID: <20070213061024.7BB35DDD0C@ozlabs.org> (raw)
In-Reply-To: <20070213060904.GA6214@localhost.localdomain>

udbg_early_init() is a function used on 64 bit systems, which
initializes whichever early udbg backend is configured.  This function
is not called on 32-bit, however if btext early debug is enabled it
does have an explicit, inline, #ifdef-ed assignment performing
analagous initialization.

This patch makes things more uniform by folding the btext
initialization as an option into udbg_early_init() and calling that
from the 32-bit setup path.

Signed-off-by: David Gibson <dwg@au1.ibm.com>
---

 arch/powerpc/kernel/btext.c    |    9 +++++++++
 arch/powerpc/kernel/setup_32.c |    8 ++------
 arch/powerpc/kernel/udbg.c     |    2 ++
 include/asm-powerpc/udbg.h     |    1 +
 4 files changed, 14 insertions(+), 6 deletions(-)

Index: working-2.6/arch/powerpc/kernel/btext.c
===================================================================
--- working-2.6.orig/arch/powerpc/kernel/btext.c	2007-01-24 12:01:17.000000000 +1100
+++ working-2.6/arch/powerpc/kernel/btext.c	2007-02-13 15:53:18.000000000 +1100
@@ -18,6 +18,7 @@
 #include <asm/io.h>
 #include <asm/lmb.h>
 #include <asm/processor.h>
+#include <asm/udbg.h>
 
 #define NO_SCROLL
 
@@ -912,3 +913,11 @@ static unsigned char vga_font[cmapsz] = 
 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
 0x00, 0x00, 0x00, 0x00,
 };
+
+void __init udbg_init_btext(void)
+{
+	/* If btext is enabled, we might have a BAT setup for early display,
+	 * thus we do enable some very basic udbg output
+	 */
+	udbg_putc = btext_drawchar;
+}
Index: working-2.6/arch/powerpc/kernel/setup_32.c
===================================================================
--- working-2.6.orig/arch/powerpc/kernel/setup_32.c	2007-02-09 09:57:55.000000000 +1100
+++ working-2.6/arch/powerpc/kernel/setup_32.c	2007-02-13 15:50:54.000000000 +1100
@@ -116,12 +116,8 @@ unsigned long __init early_init(unsigned
  */
 void __init machine_init(unsigned long dt_ptr, unsigned long phys)
 {
-	/* If btext is enabled, we might have a BAT setup for early display,
-	 * thus we do enable some very basic udbg output
-	 */
-#ifdef CONFIG_BOOTX_TEXT
-	udbg_putc = btext_drawchar;
-#endif
+	/* Enable early debugging if any specified (see udbg.h) */
+	udbg_early_init();
 
 	/* Do some early initialization based on the flat device tree */
 	early_init_devtree(__va(dt_ptr));
Index: working-2.6/arch/powerpc/kernel/udbg.c
===================================================================
--- working-2.6.orig/arch/powerpc/kernel/udbg.c	2007-02-09 09:57:55.000000000 +1100
+++ working-2.6/arch/powerpc/kernel/udbg.c	2007-02-13 15:50:54.000000000 +1100
@@ -49,6 +49,8 @@ void __init udbg_early_init(void)
 	udbg_init_debug_beat();
 #elif defined(CONFIG_PPC_EARLY_DEBUG_PAS_REALMODE)
 	udbg_init_pas_realmode();
+#elif defined(CONFIG_BOOTX_TEXT)
+	udbg_init_btext();
 #endif
 }
 
Index: working-2.6/include/asm-powerpc/udbg.h
===================================================================
--- working-2.6.orig/include/asm-powerpc/udbg.h	2007-02-09 09:57:55.000000000 +1100
+++ working-2.6/include/asm-powerpc/udbg.h	2007-02-13 15:50:54.000000000 +1100
@@ -46,6 +46,7 @@ extern void __init udbg_init_iseries(voi
 extern void __init udbg_init_rtas_panel(void);
 extern void __init udbg_init_rtas_console(void);
 extern void __init udbg_init_debug_beat(void);
+extern void __init udbg_init_btext(void);
 
 #endif /* __KERNEL__ */
 #endif /* _ASM_POWERPC_UDBG_H */

  reply	other threads:[~2007-02-13  6:10 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13  6:09 [0/16] Preliminary Ebony (440GP) support for arch/powerpc David Gibson
2007-02-13  6:10 ` David Gibson [this message]
2007-02-13  6:22   ` [PATCH 3/16] [powerpc] Use udbg_early_init() on ppc32 Benjamin Herrenschmidt
2007-02-13  6:10 ` [PATCH 6/16] Port 44x MMU definitions to ARCH=powerpc David Gibson
2007-02-13  6:24   ` Benjamin Herrenschmidt
2007-02-13 17:13     ` Roland Dreier
2007-02-13 17:45       ` Josh Boyer
2007-02-13 21:36       ` Benjamin Herrenschmidt
2007-02-13  6:10 ` [PATCH 5/16] powerpc: Add zImage platform hook for kernel address David Gibson
2007-02-13  6:10 ` [PATCH 4/16] powerpc: Allow duplicate lmb_reserve() calls David Gibson
2007-02-13  7:05   ` Michael Neuling
2007-02-13  8:48     ` Michael Ellerman
2007-02-13 20:44     ` Benjamin Herrenschmidt
2007-02-13  6:10 ` [PATCH 8/16] Define FIXED_PORT flag for serial_core David Gibson
2007-02-13  6:10 ` [PATCH 7/16] Early serial debug support for PPC44x David Gibson
2007-02-13 15:04   ` Josh Boyer
2007-02-14  0:16     ` David Gibson
2007-02-14  1:02       ` Josh Boyer
2007-02-14  1:00         ` David Gibson
2007-02-14  2:00           ` Alan Modra
2007-02-14  2:02             ` David Gibson
2007-02-14  2:38               ` Alan Modra
2007-02-14 15:41                 ` Josh Boyer
2007-02-14 23:05                   ` David Gibson
2007-02-13  6:10 ` [PATCH 2/16] More DCR native fixups David Gibson
2007-02-13  6:22   ` Benjamin Herrenschmidt
2007-02-13  6:10 ` [PATCH 1/16] Remove ibm4{xx,4x}.h from arch/powerpc David Gibson
2007-02-13 14:19   ` Josh Boyer
2007-02-13  6:10 ` [PATCH 10/16] Add support for BSS stack for zImage wrapper David Gibson
2007-02-13  6:10 ` [PATCH 9/16] Use resource_size_t for serial port IO addresses David Gibson
2007-02-13  6:10 ` [PATCH 13/16] Add initrd properties to device tree from zImage David Gibson
2007-02-13  6:10 ` [PATCH 11/16] zImage wrapper for Ebony David Gibson
2007-02-13 17:05   ` Geoff Levand
2007-02-14  0:17     ` David Gibson
2007-02-13  6:10 ` [PATCH 14/16] Add arch/powerpc driver for UIC, PPC4xx interrupt controller David Gibson
2007-02-13  6:10 ` [PATCH 12/16] Automatically lmb_reserve() initrd David Gibson
2007-02-13  7:14   ` Michael Neuling
2007-02-13  6:10 ` [PATCH 15/16] Add device tree for Ebony David Gibson
2007-02-13 20:08   ` Segher Boessenkool
2007-02-14  0:22     ` David Gibson
2007-02-14  1:51       ` Benjamin Herrenschmidt
2007-02-14  4:46         ` David Gibson
2007-02-14 17:54           ` Segher Boessenkool
2007-02-14 23:18             ` David Gibson
2007-02-15  0:25               ` Segher Boessenkool
2007-02-14 17:51         ` Segher Boessenkool
2007-02-14 17:48       ` Segher Boessenkool
2007-02-14 21:30         ` Benjamin Herrenschmidt
2007-02-15  0:03           ` Segher Boessenkool
2007-02-15  0:53             ` Benjamin Herrenschmidt
2007-02-15  1:00               ` Segher Boessenkool
2007-02-15  2:22                 ` Benjamin Herrenschmidt
2007-02-15  2:51                   ` Segher Boessenkool
2007-02-14 23:17         ` David Gibson
2007-02-15  0:27           ` Segher Boessenkool
2007-02-15 14:02             ` Jon Loeliger
2007-02-15 14:56               ` Segher Boessenkool
2007-02-15 17:02                 ` Yoder Stuart-B08248
2007-02-15 17:10                   ` Scott Wood
2007-02-16  9:20                   ` Segher Boessenkool
2007-02-14 16:14   ` Yoder Stuart-B08248
2007-02-14 16:32     ` Josh Boyer
2007-02-14 17:58       ` Segher Boessenkool
2007-02-14 20:08         ` Yoder Stuart-B08248
2007-02-14 21:12           ` Segher Boessenkool
2007-02-14 21:35             ` Yoder Stuart-B08248
2007-02-14 21:42               ` Benjamin Herrenschmidt
2007-02-14 21:59                 ` Scott Wood
2007-02-15  0:20                   ` Segher Boessenkool
2007-02-14 22:50                 ` Yoder Stuart-B08248
2007-02-14 22:57                   ` Benjamin Herrenschmidt
2007-02-15  0:17                 ` Segher Boessenkool
2007-02-15  2:12                   ` Paul Mackerras
2007-02-15  2:43                     ` Segher Boessenkool
2007-02-15  3:15                       ` Paul Mackerras
2007-02-15 14:40                         ` Segher Boessenkool
2007-02-16  1:17                           ` Paul Mackerras
2007-02-16  9:41                             ` Segher Boessenkool
2007-02-15  0:10               ` Segher Boessenkool
2007-02-14 23:32             ` David Gibson
2007-02-14 23:27           ` David Gibson
2007-02-14 23:22         ` David Gibson
2007-02-14 23:51           ` Benjamin Herrenschmidt
2007-02-15  0:36             ` Segher Boessenkool
2007-02-15  0:31           ` Segher Boessenkool
2007-02-15  1:53             ` David Gibson
2007-02-15  3:09               ` Segher Boessenkool
2007-02-15  3:33                 ` David Gibson
2007-02-15 14:47                   ` Segher Boessenkool
2007-02-15 10:52                 ` Benjamin Herrenschmidt
2007-02-15 14:52                   ` Segher Boessenkool
2007-02-15 20:43                     ` Benjamin Herrenschmidt
2007-02-16  9:23                       ` Segher Boessenkool
2007-02-15 16:37                 ` Yoder Stuart-B08248
2007-02-15 21:41                   ` Benjamin Herrenschmidt
2007-02-16  9:25                     ` Segher Boessenkool
2007-02-16 15:32                     ` Hartmut Penner
2007-02-16 16:47                       ` Yoder Stuart-B08248
2007-02-19 12:02                         ` Hartmut Penner
2007-02-14 21:29       ` Benjamin Herrenschmidt
2007-02-13  6:10 ` [PATCH 16/16] Support for Ebony in arch/powerpc David Gibson
2007-02-13 17:18   ` Roland Dreier
2007-02-14  0:20     ` David Gibson
2007-02-13 14:37 ` [0/16] Preliminary Ebony (440GP) support for arch/powerpc Josh Boyer
2007-02-13 20:21   ` Josh Boyer
2007-02-13 15:46 ` Josh Boyer
2007-02-14 16:06   ` Josh Boyer
2007-02-14 23:12     ` David Gibson
2007-02-16  2:19       ` Josh Boyer
2007-02-16  2:53         ` David Gibson
2007-02-16  4:33           ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070213061024.7BB35DDD0C@ozlabs.org \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.