Re: [PATCH] ACPI: bay: use IS_ERR for return of register_platform_device_simple

[Len Brown <lenb@kernel.org>]

Applied,

thanks,
-Len

On Wednesday 14 February 2007 07:55, Henrique de Moraes Holschuh wrote:
> register_platform_device_simple returns ERR_PTR(foo), so test it with
> IS_ERR(foo).
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> 
> ---
> 
> I wonder how many of these are in the kernel?  An annotation for this would be
> a good idea.  It doesn't help that people, as usual, do not see fit to document
> how the heck they return errors, so you have to track down the source of every
> function you are not intimately familiar with before using it.
> ---
>  drivers/acpi/bay.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> index dcf5f42..fb3f31b 100644
> --- a/drivers/acpi/bay.c
> +++ b/drivers/acpi/bay.c
> @@ -281,7 +281,7 @@ static int bay_add(acpi_handle handle, int id)
>  
>  	/* initialize platform device stuff */
>  	pdev = platform_device_register_simple(ACPI_BAY_CLASS, id, NULL, 0);
> -	if (pdev == NULL) {
> +	if (IS_ERR(pdev)) {
>  		printk(KERN_ERR PREFIX "Error registering bay device\n");
>  		goto bay_add_err;
>  	}
> -- 
> 1.4.4.4
>