All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
	stable@kernel.org, Andi Kleen <ak@suse.de>,
	Jeff Dike <jdike@addtoit.com>,
	linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: Re: x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
Date: Wed, 14 Feb 2007 21:54:23 -0500	[thread overview]
Message-ID: <20070215025423.GA9300@ccure.user-mode-linux.org> (raw)
In-Reply-To: <11715068631914-git-send-email-blaisorblade@yahoo.it>

On Thu, Feb 15, 2007 at 03:34:23AM +0100, Paolo 'Blaisorblade' Giarrusso wrote:
> Index: linux-2.6.git/arch/x86_64/ia32/ptrace32.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86_64/ia32/ptrace32.c
> +++ linux-2.6.git/arch/x86_64/ia32/ptrace32.c
> @@ -246,6 +246,7 @@ asmlinkage long sys32_ptrace(long reques
>  	case PTRACE_SINGLESTEP:
>  	case PTRACE_DETACH:
>  	case PTRACE_SYSCALL:
> +	case PTRACE_OLDSETOPTIONS:
>  	case PTRACE_SETOPTIONS:
>  	case PTRACE_SET_THREAD_AREA:
>  	case PTRACE_GET_THREAD_AREA:
> 

I sent an equivalent patch in earlier today:

Index: linux-2.6/arch/x86_64/ia32/ptrace32.c
===================================================================
--- linux-2.6.orig/arch/x86_64/ia32/ptrace32.c
+++ linux-2.6/arch/x86_64/ia32/ptrace32.c
@@ -239,6 +239,8 @@ asmlinkage long sys32_ptrace(long reques
 	__u32 val;
 
 	switch (request) { 
+	case PTRACE_OLDSETOPTIONS:
+		request = PTRACE_SETOPTIONS;
 	case PTRACE_TRACEME:
 	case PTRACE_ATTACH:
 	case PTRACE_KILL:

I change the request so that PTRACE_OLDSETOPTIONS doesn't need to
propogate any further.  However, it is present in include/asm-x86_64,
so I guess that counts as being part of the x86_64 ABI.  That being
the case, I guess my patch can be dropped in favor of this one.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
	user-mode-linux-devel@lists.sourceforge.net,
	Jeff Dike <jdike@addtoit.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
	stable@kernel.org
Subject: Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
Date: Wed, 14 Feb 2007 21:54:23 -0500	[thread overview]
Message-ID: <20070215025423.GA9300@ccure.user-mode-linux.org> (raw)
In-Reply-To: <11715068631914-git-send-email-blaisorblade@yahoo.it>

On Thu, Feb 15, 2007 at 03:34:23AM +0100, Paolo 'Blaisorblade' Giarrusso wrote:
> Index: linux-2.6.git/arch/x86_64/ia32/ptrace32.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86_64/ia32/ptrace32.c
> +++ linux-2.6.git/arch/x86_64/ia32/ptrace32.c
> @@ -246,6 +246,7 @@ asmlinkage long sys32_ptrace(long reques
>  	case PTRACE_SINGLESTEP:
>  	case PTRACE_DETACH:
>  	case PTRACE_SYSCALL:
> +	case PTRACE_OLDSETOPTIONS:
>  	case PTRACE_SETOPTIONS:
>  	case PTRACE_SET_THREAD_AREA:
>  	case PTRACE_GET_THREAD_AREA:
> 

I sent an equivalent patch in earlier today:

Index: linux-2.6/arch/x86_64/ia32/ptrace32.c
===================================================================
--- linux-2.6.orig/arch/x86_64/ia32/ptrace32.c
+++ linux-2.6/arch/x86_64/ia32/ptrace32.c
@@ -239,6 +239,8 @@ asmlinkage long sys32_ptrace(long reques
 	__u32 val;
 
 	switch (request) { 
+	case PTRACE_OLDSETOPTIONS:
+		request = PTRACE_SETOPTIONS;
 	case PTRACE_TRACEME:
 	case PTRACE_ATTACH:
 	case PTRACE_KILL:

I change the request so that PTRACE_OLDSETOPTIONS doesn't need to
propogate any further.  However, it is present in include/asm-x86_64,
so I guess that counts as being part of the x86_64 ABI.  That being
the case, I guess my patch can be dropped in favor of this one.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2007-02-15  3:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15  2:34 x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Paolo 'Blaisorblade' Giarrusso
2007-02-15  2:34 ` [uml-devel] " Paolo 'Blaisorblade' Giarrusso
2007-02-15  2:54 ` Jeff Dike [this message]
2007-02-15  2:54   ` Jeff Dike
2007-02-15  3:43   ` Blaisorblade
2007-02-15  3:43     ` Blaisorblade
2007-02-15  5:51     ` Andrew Morton
2007-02-15  5:51       ` Andrew Morton
2007-02-15 17:01       ` Jeff Dike
2007-02-15 17:01         ` Jeff Dike
2007-02-15 19:05         ` Blaisorblade
2007-02-15 19:05           ` Blaisorblade
2007-02-16 19:02           ` Jeff Dike
2007-02-16 19:02             ` Jeff Dike
2007-02-17  0:04             ` Blaisorblade
2007-02-17  0:04               ` Blaisorblade
2007-02-17  0:38               ` Jeff Dike
2007-02-17  0:38                 ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070215025423.GA9300@ccure.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=blaisorblade@yahoo.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.