* - r-o-bind-mounts-mount_is_safe-add-comment.patch removed from -mm tree
@ 2007-02-15 8:33 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2007-02-15 8:33 UTC (permalink / raw)
To: hansendc, haveblue, hch, miklos, viro, mm-commits
The patch titled
r/o bind mounts: mount_is_safe(): add comment
has been removed from the -mm tree. Its filename was
r-o-bind-mounts-mount_is_safe-add-comment.patch
This patch was dropped because it had testing failures
------------------------------------------------------
Subject: r/o bind mounts: mount_is_safe(): add comment
From: Dave Hansen <hansendc@us.ibm.com>
This area of code is currently #ifdef'd out, so add a comment for the time
when it is actually used.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/namespace.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN fs/namespace.c~r-o-bind-mounts-mount_is_safe-add-comment fs/namespace.c
--- a/fs/namespace.c~r-o-bind-mounts-mount_is_safe-add-comment
+++ a/fs/namespace.c
@@ -691,6 +691,10 @@ static int mount_is_safe(struct nameidat
if (current->uid != nd->dentry->d_inode->i_uid)
return -EPERM;
}
+ /*
+ * We will eventually check for the mnt->writer_count here,
+ * but since the code is not used now, skip it - Dave Hansen
+ */
if (vfs_permission(nd, MAY_WRITE))
return -EPERM;
return 0;
_
Patches currently in -mm which might be from hansendc@us.ibm.com are
r-o-bind-mounts-mount_is_safe-add-comment.patch
r-o-bind-mounts-unix_find_other-elevate-write-count-for-touch_atime.patch
r-o-bind-mounts-elevate-write-count-over-calls-to-vfs_rename.patch
r-o-bind-mounts-elevate-write-count-files-are-opened.patch
r-o-bind-mounts-nfs-check-mnt-instead-of-sb.patch
r-o-bind-mounts-elevate-writer-count-for-do_sys_truncate.patch
r-o-bind-mounts-elevate-write-count-for-do_utimes.patch
r-o-bind-mounts-elevate-write-count-for-do_sys_utime-and-touch_atime.patch
r-o-bind-mounts-sys_mknodat-elevate-write-count-for-vfs_mknod-create.patch
r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers.patch
r-o-bind-mounts-do_rmdir-elevate-write-count.patch
r-o-bind-mounts-elevate-writer-count-for-custom-struct_file.patch
r-o-bind-mounts-remove-is_rdonly-from-permission.patch
r-o-bind-mounts-reiser4-remove-is_rdonly-checks.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* - r-o-bind-mounts-mount_is_safe-add-comment.patch removed from -mm tree
@ 2007-02-14 18:52 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2007-02-14 18:52 UTC (permalink / raw)
To: hansendc, haveblue, hch, linuxram, miklos, viro, mm-commits
The patch titled
r/o bind mounts: mount_is_safe(): add comment
has been removed from the -mm tree. Its filename was
r-o-bind-mounts-mount_is_safe-add-comment.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
Subject: r/o bind mounts: mount_is_safe(): add comment
From: Dave Hansen <hansendc@us.ibm.com>
This area of code is currently #ifdef'd out, so add a comment for the time
when it is actually used.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Ram Pai <linuxram@us.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/namespace.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN fs/namespace.c~r-o-bind-mounts-mount_is_safe-add-comment fs/namespace.c
--- a/fs/namespace.c~r-o-bind-mounts-mount_is_safe-add-comment
+++ a/fs/namespace.c
@@ -729,6 +729,10 @@ static int mount_is_safe(struct nameidat
if (current->uid != nd->dentry->d_inode->i_uid)
return -EPERM;
}
+ /*
+ * We will eventually check for the mnt->writer_count here,
+ * but since the code is not used now, skip it - Dave Hansen
+ */
if (vfs_permission(nd, MAY_WRITE))
return -EPERM;
return 0;
_
Patches currently in -mm which might be from hansendc@us.ibm.com are
r-o-bind-mounts-mount_is_safe-add-comment.patch
r-o-bind-mounts-unix_find_other-elevate-write-count-for-touch_atime.patch
r-o-bind-mounts-elevate-write-count-over-calls-to-vfs_rename.patch
r-o-bind-mounts-elevate-write-count-files-are-opened.patch
r-o-bind-mounts-elevate-writer-count-for-do_sys_truncate.patch
r-o-bind-mounts-elevate-write-count-for-do_utimes.patch
r-o-bind-mounts-elevate-write-count-for-do_sys_utime-and-touch_atime.patch
r-o-bind-mounts-sys_mknodat-elevate-write-count-for-vfs_mknod-create.patch
r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers.patch
r-o-bind-mounts-do_rmdir-elevate-write-count.patch
r-o-bind-mounts-elevate-writer-count-for-custom-struct_file.patch
r-o-bind-mounts-gfs-check-nlink-count.patch
r-o-bind-mounts-honor-r-w-changes-at-do_remount-time.patch
r-o-bind-mounts-kill-open-files-traverse-on-remount-ro.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-15 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 8:33 - r-o-bind-mounts-mount_is_safe-add-comment.patch removed from -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2007-02-14 18:52 akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.