* [PATCH] HIL: fix improper call of release_region
@ 2007-02-15 17:50 Cyrill V. Gorcunov
2007-02-15 18:54 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Cyrill V. Gorcunov @ 2007-02-15 17:50 UTC (permalink / raw)
To: Helge Deller; +Cc: linux-kernel-list, Andrew Morton
Thist patch prevents from improper call of release_region
if the code has been compiled without CONFIG_HP300 support.
Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
---
drivers/input/keyboard/hilkbd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
index 255a6ec..c3c0da3 100644
--- a/drivers/input/keyboard/hilkbd.c
+++ b/drivers/input/keyboard/hilkbd.c
@@ -294,7 +294,9 @@ err3:
disable_irq(HIL_IRQ);
free_irq(HIL_IRQ, hil_dev.dev_id);
err2:
+#if defined(CONFIG_HP300)
release_region(HILBASE + HIL_DATA, 2);
+#endif
err1:
input_free_device(hil_dev.dev);
hil_dev.dev = NULL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HIL: fix improper call of release_region
2007-02-15 17:50 [PATCH] HIL: fix improper call of release_region Cyrill V. Gorcunov
@ 2007-02-15 18:54 ` Helge Deller
2007-02-15 19:17 ` Cyrill V. Gorcunov
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2007-02-15 18:54 UTC (permalink / raw)
To: Cyrill V. Gorcunov; +Cc: linux-kernel-list, Andrew Morton
Hi Cyrill,
please include the "err1" label as well inside the #if / #endif clause.
err1 is used only when CONFIG_HP300 is defined and in the parisc-case you currently get an unused label warning...
Helge
On Thursday 15 February 2007, Cyrill V. Gorcunov wrote:
> Thist patch prevents from improper call of release_region
> if the code has been compiled without CONFIG_HP300 support.
>
> Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
>
> ---
>
> drivers/input/keyboard/hilkbd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
> index 255a6ec..c3c0da3 100644
> --- a/drivers/input/keyboard/hilkbd.c
> +++ b/drivers/input/keyboard/hilkbd.c
> @@ -294,7 +294,9 @@ err3:
> disable_irq(HIL_IRQ);
> free_irq(HIL_IRQ, hil_dev.dev_id);
> err2:
> +#if defined(CONFIG_HP300)
> release_region(HILBASE + HIL_DATA, 2);
> +#endif
> err1:
> input_free_device(hil_dev.dev);
> hil_dev.dev = NULL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HIL: fix improper call of release_region
2007-02-15 18:54 ` Helge Deller
@ 2007-02-15 19:17 ` Cyrill V. Gorcunov
0 siblings, 0 replies; 3+ messages in thread
From: Cyrill V. Gorcunov @ 2007-02-15 19:17 UTC (permalink / raw)
To: Helge Deller; +Cc: Andrew Morton, linux-kernel-list
On Thu, Feb 15, 2007 at 07:54:33PM +0100, Helge Deller wrote:
| Hi Cyrill,
|
| please include the "err1" label as well inside the #if / #endif clause.
| err1 is used only when CONFIG_HP300 is defined and in the parisc-case you currently get an unused label warning...
|
| Helge
|
| On Thursday 15 February 2007, Cyrill V. Gorcunov wrote:
| > Thist patch prevents from improper call of release_region
| > if the code has been compiled without CONFIG_HP300 support.
| >
| > Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
| >
| > ---
| >
| > drivers/input/keyboard/hilkbd.c | 2 ++
| > 1 files changed, 2 insertions(+), 0 deletions(-)
| >
| > diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
| > index 255a6ec..c3c0da3 100644
| > --- a/drivers/input/keyboard/hilkbd.c
| > +++ b/drivers/input/keyboard/hilkbd.c
| > @@ -294,7 +294,9 @@ err3:
| > disable_irq(HIL_IRQ);
| > free_irq(HIL_IRQ, hil_dev.dev_id);
| > err2:
| > +#if defined(CONFIG_HP300)
| > release_region(HILBASE + HIL_DATA, 2);
| > +#endif
| > err1:
| > input_free_device(hil_dev.dev);
| > hil_dev.dev = NULL;
| >
|
|
Indeed. Give me a minute. (Damn, how could I get a such mistake ;)
--
Cyrill
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-15 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 17:50 [PATCH] HIL: fix improper call of release_region Cyrill V. Gorcunov
2007-02-15 18:54 ` Helge Deller
2007-02-15 19:17 ` Cyrill V. Gorcunov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.