* [PATCH 1/1] - acpi_boot_init() making bad check on return code
@ 2007-02-16 21:07 ` John Keller
0 siblings, 0 replies; 4+ messages in thread
From: John Keller @ 2007-02-16 21:07 UTC (permalink / raw)
To: linux-acpi; +Cc: ayoung, linux-ia64, linux-kernel, John Keller
acpi_boot_init() is making a bad check on the return
status from acpi_table_parse(). acpi_table_parse() now
returns zero on success, one on failure.
Signed-off-by: Aaron Young <ayoung@sgi.com>
---
Index: release/arch/ia64/kernel/acpi.c
===================================================================
--- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
+++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
@@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
* information -- the successor to MPS tables.
*/
- if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
+ if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
printk(KERN_ERR PREFIX "Can't find MADT\n");
goto skip_madt;
}
@@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
* gets interrupts such as power and sleep buttons. If it's not
* on a Legacy interrupt, it needs to be setup.
*/
- if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
+ if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
printk(KERN_ERR PREFIX "Can't find FADT\n");
#ifdef CONFIG_SMP
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] - acpi_boot_init() making bad check on return code
@ 2007-02-16 21:07 ` John Keller
0 siblings, 0 replies; 4+ messages in thread
From: John Keller @ 2007-02-16 21:07 UTC (permalink / raw)
To: linux-acpi; +Cc: ayoung, linux-ia64, linux-kernel, John Keller
acpi_boot_init() is making a bad check on the return
status from acpi_table_parse(). acpi_table_parse() now
returns zero on success, one on failure.
Signed-off-by: Aaron Young <ayoung@sgi.com>
---
Index: release/arch/ia64/kernel/acpi.c
=================================--- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
+++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
@@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
* information -- the successor to MPS tables.
*/
- if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
+ if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
printk(KERN_ERR PREFIX "Can't find MADT\n");
goto skip_madt;
}
@@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
* gets interrupts such as power and sleep buttons. If it's not
* on a Legacy interrupt, it needs to be setup.
*/
- if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
+ if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
printk(KERN_ERR PREFIX "Can't find FADT\n");
#ifdef CONFIG_SMP
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] - acpi_boot_init() making bad check on return code
2007-02-16 21:07 ` John Keller
@ 2007-02-17 3:04 ` Len Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Len Brown @ 2007-02-17 3:04 UTC (permalink / raw)
To: John Keller; +Cc: linux-acpi, ayoung, linux-ia64, linux-kernel
Applied.
thanks,
-Len
On Friday 16 February 2007 16:07, John Keller wrote:
> acpi_boot_init() is making a bad check on the return
> status from acpi_table_parse(). acpi_table_parse() now
> returns zero on success, one on failure.
>
> Signed-off-by: Aaron Young <ayoung@sgi.com>
> ---
>
> Index: release/arch/ia64/kernel/acpi.c
> ===================================================================
> --- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
> +++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
> @@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
> * information -- the successor to MPS tables.
> */
>
> - if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
> + if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
> printk(KERN_ERR PREFIX "Can't find MADT\n");
> goto skip_madt;
> }
> @@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
> * gets interrupts such as power and sleep buttons. If it's not
> * on a Legacy interrupt, it needs to be setup.
> */
> - if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
> + if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
> printk(KERN_ERR PREFIX "Can't find FADT\n");
>
> #ifdef CONFIG_SMP
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] - acpi_boot_init() making bad check on return code
@ 2007-02-17 3:04 ` Len Brown
0 siblings, 0 replies; 4+ messages in thread
From: Len Brown @ 2007-02-17 3:04 UTC (permalink / raw)
To: John Keller; +Cc: linux-acpi, ayoung, linux-ia64, linux-kernel
Applied.
thanks,
-Len
On Friday 16 February 2007 16:07, John Keller wrote:
> acpi_boot_init() is making a bad check on the return
> status from acpi_table_parse(). acpi_table_parse() now
> returns zero on success, one on failure.
>
> Signed-off-by: Aaron Young <ayoung@sgi.com>
> ---
>
> Index: release/arch/ia64/kernel/acpi.c
> =================================> --- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
> +++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
> @@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
> * information -- the successor to MPS tables.
> */
>
> - if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
> + if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
> printk(KERN_ERR PREFIX "Can't find MADT\n");
> goto skip_madt;
> }
> @@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
> * gets interrupts such as power and sleep buttons. If it's not
> * on a Legacy interrupt, it needs to be setup.
> */
> - if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
> + if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
> printk(KERN_ERR PREFIX "Can't find FADT\n");
>
> #ifdef CONFIG_SMP
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-02-17 3:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-16 21:07 [PATCH 1/1] - acpi_boot_init() making bad check on return code John Keller
2007-02-16 21:07 ` John Keller
2007-02-17 3:04 ` Len Brown
2007-02-17 3:04 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.