* + avr32-dma-mappingh.patch added to -mm tree
@ 2007-02-16 22:00 akpm
2007-02-19 8:30 ` Haavard Skinnemoen
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-02-16 22:00 UTC (permalink / raw)
To: mm-commits; +Cc: zambrano, hskinnemoen
The patch titled
avr32: dma-mapping.h
has been added to the -mm tree. Its filename is
avr32-dma-mappingh.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: avr32: dma-mapping.h
From: "Gary Zambrano" <zambrano@broadcom.com>
Added dma_sync_single_range_for_cpu/device to dma-mapping.h in asm-avr32 to
call dma_sync_single_for_cpu/device. This patch enables b44 to compile on
systems with these cpus. This patch was created with the assumption that
another method of dma_sync_single_range_for_cpu/device does not exist on these
architectures.
Signed-off by: Gary Zambrano <zambrano@broadcom.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/asm-avr32/dma-mapping.h | 18 ++++++++++++++++++
1 files changed, 18 insertions(+)
diff -puN include/asm-avr32/dma-mapping.h~avr32-dma-mappingh include/asm-avr32/dma-mapping.h
--- a/include/asm-avr32/dma-mapping.h~avr32-dma-mappingh
+++ a/include/asm-avr32/dma-mapping.h
@@ -242,6 +242,24 @@ dma_unmap_sg(struct device *dev, struct
{
}
+static inline void
+dma_sync_single_range_for_cpu(struct device *dev, dma_addr_t dma_handle,
+ unsigned long offset, size_t size,
+ enum dma_data_direction direction)
+{
+ /* just sync everything, that's all the pci API can do */
+ dma_sync_single_for_cpu(dev, dma_handle, offset+size, direction);
+}
+
+static inline void
+dma_sync_single_range_for_device(struct device *dev, dma_addr_t dma_handle,
+ unsigned long offset, size_t size,
+ enum dma_data_direction direction)
+{
+ /* just sync everything, that's all the pci API can do */
+ dma_sync_single_for_device(dev, dma_handle, offset+size, direction);
+}
+
/**
* dma_sync_single_for_cpu
_
Patches currently in -mm which might be from zambrano@broadcom.com are
arm-dma-mappingh.patch
avr32-dma-mappingh.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + avr32-dma-mappingh.patch added to -mm tree
2007-02-16 22:00 + avr32-dma-mappingh.patch added to -mm tree akpm
@ 2007-02-19 8:30 ` Haavard Skinnemoen
0 siblings, 0 replies; 2+ messages in thread
From: Haavard Skinnemoen @ 2007-02-19 8:30 UTC (permalink / raw)
To: akpm; +Cc: linux-arch, zambrano
On Fri, 16 Feb 2007 14:00:53 -0800
akpm@linux-foundation.org wrote:
> Subject: avr32: dma-mapping.h
> From: "Gary Zambrano" <zambrano@broadcom.com>
>
> Added dma_sync_single_range_for_cpu/device to dma-mapping.h in asm-avr32 to
> call dma_sync_single_for_cpu/device. This patch enables b44 to compile on
> systems with these cpus. This patch was created with the assumption that
> another method of dma_sync_single_range_for_cpu/device does not exist on these
> architectures.
Thanks. However, I have a couple of questions for the arch experts...
> +static inline void
> +dma_sync_single_range_for_cpu(struct device *dev, dma_addr_t dma_handle,
> + unsigned long offset, size_t size,
> + enum dma_data_direction direction)
> +{
> + /* just sync everything, that's all the pci API can do */
> + dma_sync_single_for_cpu(dev, dma_handle, offset+size, direction);
I'm a little curious about why we can't just do
dma_sync_single_for_cpu(dev, dma_handle + offset, size, direction);
instead?
Also, although not related to this patch in particular, I wonder if we
actually need to sync anything at all in the _for_cpu() functions.
These are analogous to dma_unmap_*(), right?
Haavard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-19 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-16 22:00 + avr32-dma-mappingh.patch added to -mm tree akpm
2007-02-19 8:30 ` Haavard Skinnemoen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.