All of lore.kernel.org
 help / color / mirror / Atom feed
* - pa-risc-fix-bogus-warnings-from-modpost.patch removed from -mm tree
@ 2007-02-17  7:17 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2007-02-17  7:17 UTC (permalink / raw)
  To: matthew, kyle, sam, mm-commits


The patch titled
     PA-RISC: Fix bogus warnings from modpost
has been removed from the -mm tree.  Its filename was
     pa-risc-fix-bogus-warnings-from-modpost.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: PA-RISC: Fix bogus warnings from modpost
From: Matthew Wilcox <matthew@wil.cx>

parisc and parisc64 seem to name sections a little differently from other
targets.  parisc64 gives spurious warnings like:

WARNING: drivers/net/dummy.o - Section mismatch: reference to .init.text:dummy_setup from .data.rel.ro between '.LC1' (at offset 0x0) and '.LC6'

and parisc gives spurious warnings like:

WARNING: drivers/net/dummy.o - Section mismatch: reference to .init.text:dummy_setup from .rodata.cst4 between '.LC1' (at offset 0x0) and '.LC6'

Given the other comments in modpost.c, it seems that the best solution is
to move rodata down to the 'match at start of name' section and add
.data.rel.ro to the 'match entire name' section.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/mod/modpost.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN scripts/mod/modpost.c~pa-risc-fix-bogus-warnings-from-modpost scripts/mod/modpost.c
--- a/scripts/mod/modpost.c~pa-risc-fix-bogus-warnings-from-modpost
+++ a/scripts/mod/modpost.c
@@ -941,7 +941,7 @@ static int init_section_ref_ok(const cha
 		".opd",   /* see comment [OPD] at exit_section_ref_ok() */
 		".toc1",  /* used by ppc64 */
 		".stab",
-		".rodata",
+		".data.rel.ro", /* used by parisc64 */
 		".parainstructions",
 		".text.lock",
 		"__bug_table", /* used by powerpc for BUG() */
@@ -964,6 +964,7 @@ static int init_section_ref_ok(const cha
 		".eh_frame",
 		".debug",
 		".parainstructions",
+		".rodata",
 		NULL
 	};
 	/* part of section name */
_

Patches currently in -mm which might be from matthew@wil.cx are

origin.patch
make-sure-nobodys-leaking-resources.patch

^ permalink raw reply	[flat|nested] 2+ messages in thread

* - pa-risc-fix-bogus-warnings-from-modpost.patch removed from -mm tree
@ 2006-12-07 22:15 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2006-12-07 22:15 UTC (permalink / raw)
  To: matthew, sam, mm-commits


The patch titled
     PA-RISC: Fix bogus warnings from modpost
has been removed from the -mm tree.  Its filename was
     pa-risc-fix-bogus-warnings-from-modpost.patch

This patch was dropped because between patch(1) silliness and me trying to fix rejects, this patch now appears to be 100% wrong

------------------------------------------------------
Subject: PA-RISC: Fix bogus warnings from modpost
From: Matthew Wilcox <matthew@wil.cx>

parisc and parisc64 seem to name sections a little differently from other
targets.  parisc64 gives spurious warnings like:

WARNING: drivers/net/dummy.o - Section mismatch: reference to .init.text:dummy_setup from .data.rel.ro between '.LC1' (at offset 0x0) and '.LC6'

and parisc gives spurious warnings like:

WARNING: drivers/net/dummy.o - Section mismatch: reference to .init.text:dummy_setup from .rodata.cst4 between '.LC1' (at offset 0x0) and '.LC6'

Given the other comments in modpost.c, it seems that the best solution is
to move rodata down to the 'match at start of name' section and add
.data.rel.ro to the 'match entire name' section.

Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 scripts/mod/modpost.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN scripts/mod/modpost.c~pa-risc-fix-bogus-warnings-from-modpost scripts/mod/modpost.c
--- a/scripts/mod/modpost.c~pa-risc-fix-bogus-warnings-from-modpost
+++ a/scripts/mod/modpost.c
@@ -910,7 +910,7 @@ static int init_section_ref_ok(const cha
 		".opd",   /* see comment [OPD] at exit_section_ref_ok() */
 		".toc1",  /* used by ppc64 */
 		".stab",
-		".rodata",
+		".data.rel.ro", /* used by parisc64 */
 		".text.lock",
 		"__bug_table", /* used by powerpc for BUG() */
 		".pci_fixup_header",
@@ -931,6 +931,7 @@ static int init_section_ref_ok(const cha
 		".altinstructions",
 		".eh_frame",
 		".debug",
+		".rodata",
 		NULL
 	};
 	/* part of section name */
_

Patches currently in -mm which might be from matthew@wil.cx are

origin.patch
pa-risc-fix-bogus-warnings-from-modpost.patch
make-sure-nobodys-leaking-resources.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-17  7:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-17  7:17 - pa-risc-fix-bogus-warnings-from-modpost.patch removed from -mm tree akpm
  -- strict thread matches above, loose matches on Subject: below --
2006-12-07 22:15 akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.