From: Andrew Morton <akpm@linux-foundation.org> To: Balbir Singh <balbir@in.ibm.com> Cc: linux-kernel@vger.kernel.org, vatsa@in.ibm.com, ckrm-tech@lists.sourceforge.net, xemul@sw.ru, linux-mm@kvack.org, menage@google.com, svaidy@linux.vnet.ibm.com, devel@openvz.org Subject: Re: [RFC][PATCH][0/4] Memory controller (RSS Control) Date: Mon, 19 Feb 2007 00:54:41 -0800 [thread overview] Message-ID: <20070219005441.7fa0eccc.akpm@linux-foundation.org> (raw) In-Reply-To: <20070219065019.3626.33947.sendpatchset@balbir-laptop> On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh <balbir@in.ibm.com> wrote: > This patch applies on top of Paul Menage's container patches (V7) posted at > > http://lkml.org/lkml/2007/2/12/88 > > It implements a controller within the containers framework for limiting > memory usage (RSS usage). It's good to see someone building on someone else's work for once, rather than everyone going off in different directions. It makes one hope that we might actually achieve something at last. The key part of this patchset is the reclaim algorithm: > @@ -636,6 +642,15 @@ static unsigned long isolate_lru_pages(u > > list_del(&page->lru); > target = src; > + /* > + * For containers, do not scan the page unless it > + * belongs to the container we are reclaiming for > + */ > + if (container && !page_in_container(page, zone, container)) { > + scan--; > + goto done; > + } Alas, I fear this might have quite bad worst-case behaviour. One small container which is under constant memory pressure will churn the system-wide LRUs like mad, and will consume rather a lot of system time. So it's a point at which container A can deleteriously affect things which are running in other containers, which is exactly what we're supposed to not do.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org> To: Balbir Singh <balbir@in.ibm.com> Cc: linux-kernel@vger.kernel.org, vatsa@in.ibm.com, ckrm-tech@lists.sourceforge.net, xemul@sw.ru, linux-mm@kvack.org, menage@google.com, svaidy@linux.vnet.ibm.com, devel@openvz.org Subject: Re: [RFC][PATCH][0/4] Memory controller (RSS Control) Date: Mon, 19 Feb 2007 00:54:41 -0800 [thread overview] Message-ID: <20070219005441.7fa0eccc.akpm@linux-foundation.org> (raw) In-Reply-To: <20070219065019.3626.33947.sendpatchset@balbir-laptop> On Mon, 19 Feb 2007 12:20:19 +0530 Balbir Singh <balbir@in.ibm.com> wrote: > This patch applies on top of Paul Menage's container patches (V7) posted at > > http://lkml.org/lkml/2007/2/12/88 > > It implements a controller within the containers framework for limiting > memory usage (RSS usage). It's good to see someone building on someone else's work for once, rather than everyone going off in different directions. It makes one hope that we might actually achieve something at last. The key part of this patchset is the reclaim algorithm: > @@ -636,6 +642,15 @@ static unsigned long isolate_lru_pages(u > > list_del(&page->lru); > target = src; > + /* > + * For containers, do not scan the page unless it > + * belongs to the container we are reclaiming for > + */ > + if (container && !page_in_container(page, zone, container)) { > + scan--; > + goto done; > + } Alas, I fear this might have quite bad worst-case behaviour. One small container which is under constant memory pressure will churn the system-wide LRUs like mad, and will consume rather a lot of system time. So it's a point at which container A can deleteriously affect things which are running in other containers, which is exactly what we're supposed to not do. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-19 9:05 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-19 6:50 [RFC][PATCH][0/4] Memory controller (RSS Control) Balbir Singh 2007-02-19 6:50 ` Balbir Singh 2007-02-19 6:50 ` [RFC][PATCH][1/4] RSS controller setup Balbir Singh 2007-02-19 6:50 ` Balbir Singh 2007-02-19 8:57 ` Andrew Morton 2007-02-19 8:57 ` Andrew Morton 2007-02-19 9:18 ` Paul Menage 2007-02-19 9:18 ` Paul Menage 2007-02-19 11:13 ` Balbir Singh 2007-02-19 11:13 ` Balbir Singh 2007-02-19 19:43 ` Matthew Helsley 2007-02-19 19:43 ` Matthew Helsley 2007-02-19 10:06 ` Balbir Singh 2007-02-19 10:06 ` Balbir Singh 2007-02-19 6:50 ` [RFC][PATCH][2/4] Add RSS accounting and control Balbir Singh 2007-02-19 6:50 ` Balbir Singh 2007-02-19 8:58 ` Andrew Morton 2007-02-19 8:58 ` Andrew Morton 2007-02-19 10:37 ` [ckrm-tech] " Balbir Singh 2007-02-19 10:37 ` Balbir Singh 2007-02-19 11:01 ` Andrew Morton 2007-02-19 11:01 ` Andrew Morton 2007-02-19 11:09 ` Balbir Singh 2007-02-19 11:09 ` Balbir Singh 2007-02-19 11:23 ` Andrew Morton 2007-02-19 11:23 ` Andrew Morton 2007-02-19 11:56 ` Balbir Singh 2007-02-19 11:56 ` Balbir Singh 2007-02-19 12:09 ` Paul Menage 2007-02-19 12:09 ` Paul Menage 2007-02-19 14:10 ` Balbir Singh 2007-02-19 14:10 ` Balbir Singh 2007-02-19 16:07 ` Vaidyanathan Srinivasan 2007-02-19 16:07 ` Vaidyanathan Srinivasan 2007-02-19 16:17 ` Balbir Singh 2007-02-19 16:17 ` Balbir Singh 2007-02-20 6:40 ` Vaidyanathan Srinivasan 2007-02-20 6:40 ` Vaidyanathan Srinivasan 2007-02-19 6:50 ` [RFC][PATCH][3/4] Add reclaim support Balbir Singh 2007-02-19 6:50 ` Balbir Singh 2007-02-19 8:59 ` Andrew Morton 2007-02-19 8:59 ` Andrew Morton 2007-02-19 10:50 ` Balbir Singh 2007-02-19 10:50 ` Balbir Singh 2007-02-19 11:10 ` Andrew Morton 2007-02-19 11:10 ` Andrew Morton 2007-02-19 11:16 ` Balbir Singh 2007-02-19 11:16 ` Balbir Singh 2007-02-19 9:48 ` KAMEZAWA Hiroyuki 2007-02-19 9:48 ` KAMEZAWA Hiroyuki 2007-02-19 10:52 ` Balbir Singh 2007-02-19 10:52 ` Balbir Singh 2007-02-19 6:50 ` [RFC][PATCH][4/4] RSS controller documentation Balbir Singh 2007-02-19 6:50 ` Balbir Singh 2007-02-19 8:54 ` Andrew Morton [this message] 2007-02-19 8:54 ` [RFC][PATCH][0/4] Memory controller (RSS Control) Andrew Morton 2007-02-19 9:06 ` Paul Menage 2007-02-19 9:06 ` Paul Menage 2007-02-19 9:50 ` [ckrm-tech] " Kirill Korotaev 2007-02-19 9:50 ` Kirill Korotaev 2007-02-19 9:50 ` Paul Menage 2007-02-19 9:50 ` Paul Menage 2007-02-19 10:24 ` Balbir Singh 2007-02-19 10:24 ` Balbir Singh 2007-02-19 10:39 ` Balbir Singh 2007-02-19 10:39 ` Balbir Singh 2007-02-19 9:16 ` Magnus Damm 2007-02-19 9:16 ` Magnus Damm 2007-02-19 10:45 ` Balbir Singh 2007-02-19 10:45 ` Balbir Singh 2007-02-19 11:56 ` Magnus Damm 2007-02-19 11:56 ` Magnus Damm 2007-02-19 14:07 ` Balbir Singh 2007-02-19 14:07 ` Balbir Singh 2007-02-19 10:00 ` Balbir Singh 2007-02-19 10:00 ` Balbir Singh 2007-02-24 14:45 [RFC][PATCH][0/4] Memory controller (RSS Control) ( Balbir Singh 2007-02-24 14:45 ` Balbir Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070219005441.7fa0eccc.akpm@linux-foundation.org \ --to=akpm@linux-foundation.org \ --cc=balbir@in.ibm.com \ --cc=ckrm-tech@lists.sourceforge.net \ --cc=devel@openvz.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=menage@google.com \ --cc=svaidy@linux.vnet.ibm.com \ --cc=vatsa@in.ibm.com \ --cc=xemul@sw.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.