All of lore.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] make remove_inode_dquot_ref() static
@ 2007-02-20  0:07 Adrian Bunk
  2007-02-20 11:22 ` Jan Kara
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2007-02-20  0:07 UTC (permalink / raw)
  To: Christoph Hellwig, jack; +Cc: linux-kernel

remove_inode_dquot_ref() can now become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 fs/dquot.c               |    3 ++-
 include/linux/quotaops.h |    3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.20-mm2/include/linux/quotaops.h.old	2007-02-18 22:27:48.000000000 +0100
+++ linux-2.6.20-mm2/include/linux/quotaops.h	2007-02-18 22:27:54.000000000 +0100
@@ -37,9 +37,6 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
-int remove_inode_dquot_ref(struct inode *inode, int type,
-			   struct list_head *tofree_head);
-
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
--- linux-2.6.20-mm2/fs/dquot.c.old	2007-02-18 22:28:03.000000000 +0100
+++ linux-2.6.20-mm2/fs/dquot.c	2007-02-18 22:28:16.000000000 +0100
@@ -721,7 +721,8 @@
 
 /* Remove references to dquots from inode - add dquot to list for freeing if needed */
 /* We can't race with anybody because we hold dqptr_sem for writing... */
-int remove_inode_dquot_ref(struct inode *inode, int type, struct list_head *tofree_head)
+static int remove_inode_dquot_ref(struct inode *inode, int type,
+				  struct list_head *tofree_head)
 {
 	struct dquot *dquot = inode->i_dquot[type];
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] make remove_inode_dquot_ref() static
  2007-02-20  0:07 [2.6 patch] make remove_inode_dquot_ref() static Adrian Bunk
@ 2007-02-20 11:22 ` Jan Kara
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2007-02-20 11:22 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Christoph Hellwig, jack, linux-kernel

On Tue 20-02-07 01:07:38, Adrian Bunk wrote:
> remove_inode_dquot_ref() can now become static.
  ACK. I should have noticed it when acking Christophs patch...

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
  Signed-off-by: Jan Kara <jack@suse.cz>

									Honza
> ---
> 
>  fs/dquot.c               |    3 ++-
>  include/linux/quotaops.h |    3 ---
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> --- linux-2.6.20-mm2/include/linux/quotaops.h.old	2007-02-18 22:27:48.000000000 +0100
> +++ linux-2.6.20-mm2/include/linux/quotaops.h	2007-02-18 22:27:54.000000000 +0100
> @@ -37,9 +37,6 @@
>  extern int dquot_commit_info(struct super_block *sb, int type);
>  extern int dquot_mark_dquot_dirty(struct dquot *dquot);
>  
> -int remove_inode_dquot_ref(struct inode *inode, int type,
> -			   struct list_head *tofree_head);
> -
>  extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
>  extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
>  		int format_id, int type);
> --- linux-2.6.20-mm2/fs/dquot.c.old	2007-02-18 22:28:03.000000000 +0100
> +++ linux-2.6.20-mm2/fs/dquot.c	2007-02-18 22:28:16.000000000 +0100
> @@ -721,7 +721,8 @@
>  
>  /* Remove references to dquots from inode - add dquot to list for freeing if needed */
>  /* We can't race with anybody because we hold dqptr_sem for writing... */
> -int remove_inode_dquot_ref(struct inode *inode, int type, struct list_head *tofree_head)
> +static int remove_inode_dquot_ref(struct inode *inode, int type,
> +				  struct list_head *tofree_head)
>  {
>  	struct dquot *dquot = inode->i_dquot[type];
>  
> 
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] make remove_inode_dquot_ref() static
  2007-03-25 14:58 Adrian Bunk
@ 2007-03-25 17:03 ` Christoph Hellwig
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2007-03-25 17:03 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, Christoph Hellwig, jack, linux-kernel

On Sun, Mar 25, 2007 at 04:58:25PM +0200, Adrian Bunk wrote:
> remove_inode_dquot_ref() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Acked-by: Jan Kara <jack@suse.cz>

Looks good to me.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [2.6 patch] make remove_inode_dquot_ref() static
@ 2007-03-25 14:58 Adrian Bunk
  2007-03-25 17:03 ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2007-03-25 14:58 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Christoph Hellwig, jack, linux-kernel

remove_inode_dquot_ref() can now become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Jan Kara <jack@suse.cz>

---

This patch was already sent on:
- 20 Feb 2007

 fs/dquot.c               |    3 ++-
 include/linux/quotaops.h |    3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.20-mm2/include/linux/quotaops.h.old	2007-02-18 22:27:48.000000000 +0100
+++ linux-2.6.20-mm2/include/linux/quotaops.h	2007-02-18 22:27:54.000000000 +0100
@@ -37,9 +37,6 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
-int remove_inode_dquot_ref(struct inode *inode, int type,
-			   struct list_head *tofree_head);
-
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
--- linux-2.6.20-mm2/fs/dquot.c.old	2007-02-18 22:28:03.000000000 +0100
+++ linux-2.6.20-mm2/fs/dquot.c	2007-02-18 22:28:16.000000000 +0100
@@ -721,7 +721,8 @@
 
 /* Remove references to dquots from inode - add dquot to list for freeing if needed */
 /* We can't race with anybody because we hold dqptr_sem for writing... */
-int remove_inode_dquot_ref(struct inode *inode, int type, struct list_head *tofree_head)
+static int remove_inode_dquot_ref(struct inode *inode, int type,
+				  struct list_head *tofree_head)
 {
 	struct dquot *dquot = inode->i_dquot[type];
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-03-25 17:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20  0:07 [2.6 patch] make remove_inode_dquot_ref() static Adrian Bunk
2007-02-20 11:22 ` Jan Kara
2007-03-25 14:58 Adrian Bunk
2007-03-25 17:03 ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.