* [2.6 patch] drivers/char/hvc_console.c: cleanups
@ 2007-02-20 0:02 Adrian Bunk
2007-02-20 0:47 ` Stephen Rothwell
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-02-20 0:02 UTC (permalink / raw)
To: linux-kernel
This patch contains the following cleanups:
- make needlessly global code static
- remove the unused EXPORT_SYMBOL's
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/char/hvc_console.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
--- linux-2.6.20-mm1/drivers/char/hvc_console.c.old 2007-02-16 14:34:20.000000000 +0100
+++ linux-2.6.20-mm1/drivers/char/hvc_console.c 2007-02-16 14:38:33.000000000 +0100
@@ -117,7 +117,7 @@
* lock held. If successful, this function increments the kobject reference
* count against the target hvc_struct so it should be released when finished.
*/
-struct hvc_struct *hvc_get_by_index(int index)
+static struct hvc_struct *hvc_get_by_index(int index)
{
struct hvc_struct *hp;
unsigned long flags;
@@ -156,7 +156,8 @@
* hvc_console_setup() finds adapters.
*/
-void hvc_console_print(struct console *co, const char *b, unsigned count)
+static void hvc_console_print(struct console *co, const char *b,
+ unsigned count)
{
char c[N_OUTBUF] __ALIGNED__;
unsigned i = 0, n = 0;
@@ -214,7 +215,7 @@
return 0;
}
-struct console hvc_con_driver = {
+static struct console hvc_con_driver = {
.name = "hvc",
.write = hvc_console_print,
.device = hvc_console_device,
@@ -284,7 +285,6 @@
return 0;
}
-EXPORT_SYMBOL(hvc_instantiate);
/* Wake the sleeping khvcd */
static void hvc_kick(void)
@@ -777,7 +777,6 @@
return hp;
}
-EXPORT_SYMBOL(hvc_alloc);
int __devexit hvc_remove(struct hvc_struct *hp)
{
@@ -813,11 +812,10 @@
tty_hangup(tty);
return 0;
}
-EXPORT_SYMBOL(hvc_remove);
/* Driver initialization. Follow console initialization. This is where the TTY
* interfaces start to become available. */
-int __init hvc_init(void)
+static int __init hvc_init(void)
{
struct tty_driver *drv;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/char/hvc_console.c: cleanups
2007-02-20 0:02 [2.6 patch] drivers/char/hvc_console.c: cleanups Adrian Bunk
@ 2007-02-20 0:47 ` Stephen Rothwell
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2007-02-20 0:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
On Tue, 20 Feb 2007 01:02:07 +0100 Adrian Bunk <bunk@stusta.de> wrote:
>
> This patch contains the following cleanups:
> - make needlessly global code static
> - remove the unused EXPORT_SYMBOL's
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-20 0:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20 0:02 [2.6 patch] drivers/char/hvc_console.c: cleanups Adrian Bunk
2007-02-20 0:47 ` Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.