All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Include git-gui credits file in dist.
@ 2007-02-22  4:49 Shawn O. Pearce
  2007-02-22  4:56 ` Shawn O. Pearce
  0 siblings, 1 reply; 2+ messages in thread
From: Shawn O. Pearce @ 2007-02-22  4:49 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

The Makefile for the git-gui subproject will fail to execute if run
outside of a git.git directory, such as when building from a .tar.gz
or .tar.bz2.  This is because it is looking for the credits file,
which was created but omitted from the tarball by the toplevel
Makefile.

---

 This has to go on `maint` before you create the release tarball
 for 1.5.0.2, otherwise 1.5.0.2 cannot be compiled outside of a
 git.git repository.

 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 289decd..35be5e2 100644
--- a/Makefile
+++ b/Makefile
@@ -895,7 +895,8 @@ dist: git.spec git-archive
 	$(TAR) rf $(GIT_TARNAME).tar \
 		$(GIT_TARNAME)/git.spec \
 		$(GIT_TARNAME)/version \
-		$(GIT_TARNAME)/git-gui/version
+		$(GIT_TARNAME)/git-gui/version \
+		$(GIT_TARNAME)/git-gui/credits
 	@rm -rf $(GIT_TARNAME)
 	gzip -f -9 $(GIT_TARNAME).tar
 
-- 
1.5.0.61.ga0bf

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Include git-gui credits file in dist.
  2007-02-22  4:49 [PATCH] Include git-gui credits file in dist Shawn O. Pearce
@ 2007-02-22  4:56 ` Shawn O. Pearce
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2007-02-22  4:56 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

"Shawn O. Pearce" <spearce@spearce.org> wrote:
> The Makefile for the git-gui subproject will fail to execute if run
> outside of a git.git directory, such as when building from a .tar.gz
> or .tar.bz2.  This is because it is looking for the credits file,
> which was created but omitted from the tarball by the toplevel
> Makefile.

Obviously I forgot this little line, sorry:

> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
 
-- 
Shawn.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-22  4:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-22  4:49 [PATCH] Include git-gui credits file in dist Shawn O. Pearce
2007-02-22  4:56 ` Shawn O. Pearce

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.