From: Luca Tettamanti <kronos@people.it> To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Cc: "Antonino A. Daplas" <adaplas@gmail.com>, James Simmons <jsimmons@infradead.org>, linux-fbdev-devel@lists.sourceforge.net, Andrew Morton <akpm@osdl.org>, Dave Airlie <airlied@gmail.com>, linux-kernel@vger.kernel.org Subject: Re: [Linux-fbdev-devel] [PATCH] nvidiafb: allow ignoring EDID info Date: Thu, 22 Feb 2007 21:39:04 +0100 [thread overview] Message-ID: <20070222203904.GA15349@dreamland.darkstar.lan> (raw) In-Reply-To: <cb7bb73a0702220001u6acbdd95ncdc9fad10d06b421@mail.gmail.com> Il Thu, Feb 22, 2007 at 09:01:52AM +0100, Giuseppe Bilotta ha scritto: > On 2/22/07, Antonino A. Daplas <adaplas@gmail.com> wrote: > >On Wed, 2007-02-07 at 00:08 +0100, Giuseppe Bilotta wrote: > >> > >> As mentioned in another post in this thread, I can't get any info out > >> of the i2c busses, because even when I have them available (i.e. after > >> loading nvidiafb) I get XXXX all around (on all three of them). > >> Suggestions on how to get the information welcome. > > > >Is this the same monitor you posted here? > > > >http://marc.theaimsgroup.com/?l=linux-kernel&m=112807065616218&w=2 > > > >If yes, we already have the manufacturer and model code. The main > >problem is that the EDID of this display has no sync range (H: 75-75kHz > >and V: 60-60Hz). Extending Hsync from 30-75kHz as a fix to the EDID > >block shouldn't be too hard. > > Yes, that's it! Jeepers, I can't believe that even re-reading the past > LKML posts (even those!) I couldn't find the EDID info and how we had > gotten them. I guess I need stronger glasses. > > Wonder why Luca's proposed patch makes the EDID undetectable, now, and > why can't it be retrieved at a later time via i2c. Timeouts too small? Still scratching my head :| Tony, this is the patch (modulo cosmetic stuff) that I sent to Giuseppe. I believe it's correct (I cross checked with X.org driver): diff --git a/drivers/video/nvidia/nv_i2c.c b/drivers/video/nvidia/nv_i2c.c index b858897..7e64341 100644 --- a/drivers/video/nvidia/nv_i2c.c +++ b/drivers/video/nvidia/nv_i2c.c @@ -70,8 +70,6 @@ static int nvidia_gpio_getscl(void *data) if (VGA_RD08(par->PCIO, 0x3d5) & 0x04) val = 1; - val = VGA_RD08(par->PCIO, 0x3d5); - return val; } Luca -- Non sempre quello che viene dopo e` progresso. Alessandro Manzoni
WARNING: multiple messages have this Message-ID (diff)
From: Luca Tettamanti <kronos@people.it> To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Cc: Andrew Morton <akpm@osdl.org>, linux-fbdev-devel@lists.sourceforge.net, "Antonino A. Daplas" <adaplas@gmail.com>, linux-kernel@vger.kernel.org, James Simmons <jsimmons@infradead.org>, Dave Airlie <airlied@gmail.com> Subject: Re: [PATCH] nvidiafb: allow ignoring EDID info Date: Thu, 22 Feb 2007 21:39:04 +0100 [thread overview] Message-ID: <20070222203904.GA15349@dreamland.darkstar.lan> (raw) In-Reply-To: <cb7bb73a0702220001u6acbdd95ncdc9fad10d06b421@mail.gmail.com> Il Thu, Feb 22, 2007 at 09:01:52AM +0100, Giuseppe Bilotta ha scritto: > On 2/22/07, Antonino A. Daplas <adaplas@gmail.com> wrote: > >On Wed, 2007-02-07 at 00:08 +0100, Giuseppe Bilotta wrote: > >> > >> As mentioned in another post in this thread, I can't get any info out > >> of the i2c busses, because even when I have them available (i.e. after > >> loading nvidiafb) I get XXXX all around (on all three of them). > >> Suggestions on how to get the information welcome. > > > >Is this the same monitor you posted here? > > > >http://marc.theaimsgroup.com/?l=linux-kernel&m=112807065616218&w=2 > > > >If yes, we already have the manufacturer and model code. The main > >problem is that the EDID of this display has no sync range (H: 75-75kHz > >and V: 60-60Hz). Extending Hsync from 30-75kHz as a fix to the EDID > >block shouldn't be too hard. > > Yes, that's it! Jeepers, I can't believe that even re-reading the past > LKML posts (even those!) I couldn't find the EDID info and how we had > gotten them. I guess I need stronger glasses. > > Wonder why Luca's proposed patch makes the EDID undetectable, now, and > why can't it be retrieved at a later time via i2c. Timeouts too small? Still scratching my head :| Tony, this is the patch (modulo cosmetic stuff) that I sent to Giuseppe. I believe it's correct (I cross checked with X.org driver): diff --git a/drivers/video/nvidia/nv_i2c.c b/drivers/video/nvidia/nv_i2c.c index b858897..7e64341 100644 --- a/drivers/video/nvidia/nv_i2c.c +++ b/drivers/video/nvidia/nv_i2c.c @@ -70,8 +70,6 @@ static int nvidia_gpio_getscl(void *data) if (VGA_RD08(par->PCIO, 0x3d5) & 0x04) val = 1; - val = VGA_RD08(par->PCIO, 0x3d5); - return val; } Luca -- Non sempre quello che viene dopo e` progresso. Alessandro Manzoni ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2007-02-22 20:39 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-01-28 10:48 [PATCH] nvidiafb: allow ignoring EDID info Giuseppe Bilotta 2007-01-28 11:05 ` Prakash Punnoor 2007-01-29 0:08 ` Andrew Morton 2007-01-29 0:08 ` Andrew Morton 2007-01-29 0:12 ` [Linux-fbdev-devel] " Dave Airlie 2007-01-29 0:12 ` Dave Airlie 2007-01-29 0:27 ` [Linux-fbdev-devel] " Andrew Morton 2007-01-29 0:27 ` Andrew Morton 2007-01-29 0:29 ` [Linux-fbdev-devel] " Andrew Morton 2007-01-29 0:29 ` Andrew Morton 2007-01-29 0:39 ` [Linux-fbdev-devel] " Dave Airlie 2007-01-29 0:39 ` Dave Airlie 2007-01-29 14:37 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-01-30 20:33 ` Luca Tettamanti 2007-01-30 20:33 ` Luca Tettamanti 2007-02-04 20:17 ` [Linux-fbdev-devel] " Luca Tettamanti 2007-02-04 21:17 ` Giuseppe Bilotta 2007-02-05 20:18 ` Luca Tettamanti 2007-02-05 20:18 ` Luca Tettamanti 2007-02-05 21:28 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-06 21:22 ` James Simmons 2007-02-06 21:22 ` James Simmons 2007-02-07 23:48 ` [Linux-fbdev-devel] " Luca Tettamanti 2007-02-07 23:48 ` Luca Tettamanti 2007-02-08 0:19 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-11 18:17 ` Luca Tettamanti 2007-02-11 18:17 ` Luca Tettamanti 2007-02-13 9:25 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-17 18:14 ` Luca Tettamanti 2007-02-17 18:14 ` Luca Tettamanti 2007-02-17 18:46 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-08 17:56 ` James Simmons 2007-02-08 17:56 ` James Simmons 2007-02-07 23:57 ` [Linux-fbdev-devel] " Luca Tettamanti 2007-02-07 23:57 ` Luca Tettamanti 2007-02-06 20:37 ` [Linux-fbdev-devel] " James Simmons 2007-02-06 23:08 ` Giuseppe Bilotta 2007-02-21 23:43 ` Antonino A. Daplas 2007-02-21 23:43 ` Antonino A. Daplas 2007-02-22 8:01 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-22 8:40 ` Antonino A. Daplas 2007-02-22 8:40 ` Antonino A. Daplas [not found] ` <cb7bb73a0702220548s55380f7fk995726ffd349823b@mail.gmail.com> [not found] ` <1172153358.4306.17.camel@daplas> 2007-02-22 15:55 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-22 16:21 ` Antonino A. Daplas 2007-02-22 16:21 ` Antonino A. Daplas 2007-02-22 19:08 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-22 23:34 ` Antonino A. Daplas 2007-02-22 23:34 ` Antonino A. Daplas 2007-02-23 13:34 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-23 13:34 ` Giuseppe Bilotta 2007-02-24 7:04 ` [Linux-fbdev-devel] " Antonino A. Daplas 2007-02-24 7:04 ` Antonino A. Daplas 2007-02-24 9:16 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-24 9:16 ` Giuseppe Bilotta 2007-02-24 21:16 ` [Linux-fbdev-devel] " Antonino A. Daplas 2007-02-25 10:26 ` Giuseppe Bilotta 2007-02-25 10:26 ` Giuseppe Bilotta 2007-02-25 11:10 ` [Linux-fbdev-devel] " Antonino A. Daplas 2007-02-25 11:10 ` Antonino A. Daplas 2007-02-25 13:16 ` [Linux-fbdev-devel] " Giuseppe Bilotta 2007-02-25 13:16 ` Giuseppe Bilotta 2007-02-26 12:46 ` [Linux-fbdev-devel] " Antonino A. Daplas 2007-02-22 17:03 ` Antonino A. Daplas 2007-02-22 20:39 ` Luca Tettamanti [this message] 2007-02-22 20:39 ` Luca Tettamanti 2007-02-22 23:34 ` [Linux-fbdev-devel] " Antonino A. Daplas 2007-02-22 23:34 ` Antonino A. Daplas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070222203904.GA15349@dreamland.darkstar.lan \ --to=kronos@people.it \ --cc=adaplas@gmail.com \ --cc=airlied@gmail.com \ --cc=akpm@osdl.org \ --cc=giuseppe.bilotta@gmail.com \ --cc=jsimmons@infradead.org \ --cc=linux-fbdev-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.