All of lore.kernel.org
 help / color / mirror / Atom feed
* GFP_DMA in sd_revalidate_disk
@ 2007-02-23 16:51 Bernhard Walle
  0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Walle @ 2007-02-23 16:51 UTC (permalink / raw)
  To: linux-scsi

Hello,

is GFP_DMA really needed in sd_revalidate_disk() in every circumstances?
That's the code:

    buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL | __GFP_DMA);
    if (!buffer) {
        printk(KERN_WARNING "(sd_revalidate_disk:) Memory allocation "
               "failure.\n");
        goto out;
    }

Or should could the check (sdp->host->unchecked_isa_dma ? __GFP_DMA : 0)
applied here, too?

Thanks!


Regards,
Bernhard

^ permalink raw reply	[flat|nested] 2+ messages in thread
* GFP_DMA in sd_revalidate_disk
@ 2007-02-26 16:08 Bernhard Walle
  0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Walle @ 2007-02-26 16:08 UTC (permalink / raw)
  To: linux-kernel

Hello,

[since I got no reply in linux-scsi, I'll try here]

Is GFP_DMA really needed in sd_revalidate_disk() in every circumstances?
That's the code:

    buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL | __GFP_DMA);
    if (!buffer) {
        printk(KERN_WARNING "(sd_revalidate_disk:) Memory allocation "
               "failure.\n");
        goto out;
    }

Or should could the check (sdp->host->unchecked_isa_dma ? __GFP_DMA : 0)
applied here, too?

Thanks!


Regards,
Bernhard

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-26 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-23 16:51 GFP_DMA in sd_revalidate_disk Bernhard Walle
2007-02-26 16:08 Bernhard Walle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.