All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, npiggin@suse.de, linux-mm@kvack.org
Subject: Re: [patch 3/3] mm: fix PageUptodate memorder
Date: Sun, 25 Feb 2007 04:06:57 -0800	[thread overview]
Message-ID: <20070225040657.eb4fc159.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070215051851.7443.65811.sendpatchset@linux.site>


What an unpleasing patchset.  I really really hope we really have a bug in
there, and that all this crap isn't pointless uglification.

We _do_ need a flush_dcaceh_page() in all cases which you're concerned
about.  Perhaps we should stick the appropriate barriers in there.

> On Thu, 15 Feb 2007 08:31:31 +0100 (CET) Nick Piggin <npiggin@suse.de> wrote:
> +static inline void SetNewPageUptodate(struct page *page)
> +{
> +	/*
> +	 * S390 sets page dirty bit on IO operations, which is why it is
> +	 * cleared in SetPageUptodate. This is not an issue for newly
> +	 * allocated pages that are brought uptodate by zeroing memory.
> +	 */
> +	smp_wmb();
> +	__set_bit(PG_uptodate, &(page)->flags);
> +}

__SetPageUptodate() might be more conventional.

Boy we'd better get the callers of this little handgrenade right.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 3/3] mm: fix PageUptodate memorder
Date: Sun, 25 Feb 2007 04:06:57 -0800	[thread overview]
Message-ID: <20070225040657.eb4fc159.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070215051851.7443.65811.sendpatchset@linux.site>

What an unpleasing patchset.  I really really hope we really have a bug in
there, and that all this crap isn't pointless uglification.

We _do_ need a flush_dcaceh_page() in all cases which you're concerned
about.  Perhaps we should stick the appropriate barriers in there.

> On Thu, 15 Feb 2007 08:31:31 +0100 (CET) Nick Piggin <npiggin@suse.de> wrote:
> +static inline void SetNewPageUptodate(struct page *page)
> +{
> +	/*
> +	 * S390 sets page dirty bit on IO operations, which is why it is
> +	 * cleared in SetPageUptodate. This is not an issue for newly
> +	 * allocated pages that are brought uptodate by zeroing memory.
> +	 */
> +	smp_wmb();
> +	__set_bit(PG_uptodate, &(page)->flags);
> +}

__SetPageUptodate() might be more conventional.

Boy we'd better get the callers of this little handgrenade right.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-02-25 12:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15  7:31 [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 4) Nick Piggin
2007-02-15  7:31 ` Nick Piggin
2007-02-15  7:31 ` [patch 1/3] mm: make read_cache_page synchronous Nick Piggin
2007-02-15  7:31   ` Nick Piggin
2007-02-15  7:31 ` [patch 2/3] fs: buffer don't PageUptodate without page locked Nick Piggin
2007-02-15  7:31   ` Nick Piggin
2007-02-15  7:31 ` [patch 3/3] mm: fix PageUptodate memorder Nick Piggin
2007-02-15  7:31   ` Nick Piggin
2007-02-25 12:06   ` Andrew Morton [this message]
2007-02-25 12:06     ` Andrew Morton
2007-02-26  2:37     ` Nick Piggin
2007-02-26  2:37       ` Nick Piggin
  -- strict thread matches above, loose matches on Subject: below --
2007-02-10  2:31 [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 3) Nick Piggin
2007-02-10  2:31 ` [patch 3/3] mm: fix PageUptodate memorder Nick Piggin
2007-02-10  2:31   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070225040657.eb4fc159.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.