All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH-2.4] fix missing parenthesis in unused macro in ip_nat_standalone
@ 2007-02-25  8:08 Willy Tarreau
  0 siblings, 0 replies; only message in thread
From: Willy Tarreau @ 2007-02-25  8:08 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Mariusz Kozlowski, davem

Hi all,

Just FYI, I've queued the following patch for 2.4.35-pre2.
Mariusz proposed to remove the unused macro (which is not
in 2.6 anymore BTW), but I don't like removing anything in
code freeze. However, fixing invalid code still seems important
to me.

Regards,
Willy

From: Willy Tarreau <w@1wt.eu>
Date: Sun, 25 Feb 2007 08:55:44 +0100
Subject: [PATCH] fix missing parenthesis in unused macro in ip_nat_standalone

The bug found by Mariusz Kozlowski affects an unused macro. However,
I prefer to fix the macro than removing it because external patches
might be relying on it.
---
 net/ipv4/netfilter/ip_nat_standalone.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/netfilter/ip_nat_standalone.c b/net/ipv4/netfilter/ip_nat_standalone.c
index 2628978..ff8935b 100644
--- a/net/ipv4/netfilter/ip_nat_standalone.c
+++ b/net/ipv4/netfilter/ip_nat_standalone.c
@@ -47,7 +47,7 @@ #define HOOKNAME(hooknum) ((hooknum) == 
 			   : ((hooknum) == NF_IP_PRE_ROUTING ? "PRE_ROUTING" \
 			      : ((hooknum) == NF_IP_LOCAL_OUT ? "LOCAL_OUT"  \
 			         : ((hooknum) == NF_IP_LOCAL_IN ? "LOCAL_IN"  \
-				    : "*ERROR*")))
+				    : "*ERROR*"))))
 
 static inline int call_expect(struct ip_conntrack *master,
 			      struct sk_buff **pskb,
-- 
1.4.2.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-25  8:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-25  8:08 [PATCH-2.4] fix missing parenthesis in unused macro in ip_nat_standalone Willy Tarreau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.