All of lore.kernel.org
 help / color / mirror / Atom feed
* + bug-in-mm_rb-debugging.patch added to -mm tree
@ 2007-02-28  6:28 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-02-28  6:28 UTC (permalink / raw)
  To: mm-commits; +Cc: davem, andrea


The patch titled
     Bug in MM_RB debugging
has been added to the -mm tree.  Its filename is
     bug-in-mm_rb-debugging.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: Bug in MM_RB debugging
From: David Miller <davem@davemloft.net>

The code is seemingly trying to make sure that rb_next() brings us to
successive increasing vma entries.

But the two variables, prev and pend, used to perform these checks, are
never advanced.

Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Andrea Arcangeli <andrea@novell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/mmap.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN mm/mmap.c~bug-in-mm_rb-debugging mm/mmap.c
--- a/mm/mmap.c~bug-in-mm_rb-debugging
+++ a/mm/mmap.c
@@ -299,6 +299,8 @@ static int browse_rb(struct rb_root *roo
 			printk("vm_end %lx < vm_start %lx\n", vma->vm_end, vma->vm_start);
 		i++;
 		pn = nd;
+		prev = vma->vm_start;
+		pend = vma->vm_end;
 	}
 	j = 0;
 	for (nd = pn; nd; nd = rb_prev(nd)) {
_

Patches currently in -mm which might be from davem@davemloft.net are

tick-schedc-build-fix.patch
generic-one-shot-bug.patch
bug-in-mm_rb-debugging.patch
git-net.patch
resend-iphase-64bit-cleanup.patch
simplify-the-stacktrace-code.patch
tg3-use-flush_keventd_work.patch
e1000-use-flush_keventd_work.patch
ipvs-flush-defense_work-before-module-unload.patch
unify-flush_work-flush_work_keventd-and-rename-it-to-cancel_work_sync.patch
atomich-add-atomic64-cmpxchg-xchg-and-add_unless-to-sparc64.patch
local_t-sparc64-cleanup.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-28  6:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-28  6:28 + bug-in-mm_rb-debugging.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.