All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wu <flamingice@sourmilk.net>
To: linux-wireless@vger.kernel.org
Subject: [PATCH 2/5] d80211: Do not require drivers to implement reset callback
Date: Wed, 28 Feb 2007 15:39:43 -0500	[thread overview]
Message-ID: <20070228203943.11473.91707.stgit@magic.sourmilk.net> (raw)
In-Reply-To: <20070228203943.11473.95222.stgit@magic.sourmilk.net>

From: Michael Wu <flamingice@sourmilk.net>

This prevents drivers from crashing if there is a TX timeout and the reset
callback isn't implemented.

Signed-off-by: Michael Wu <flamingice@sourmilk.net>
---

 net/mac80211/ieee80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index bbdf928..15344c7 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -2084,7 +2084,7 @@ static void ieee80211_tx_timeout(struct
 
 	printk(KERN_WARNING "%s: resetting interface.\n", dev->name);
 
-	if (local->ops->reset(local_to_hw(local)))
+	if (local->ops->reset && local->ops->reset(local_to_hw(local)))
 		printk(KERN_ERR "%s: failed to reset interface.\n", dev->name);
 	else
 		netif_wake_queue(dev);


  parent reply	other threads:[~2007-02-28 20:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28 20:39 [PATCH 1/5] d80211: Remove curr_rates and fix related concurrency issues Michael Wu
2007-02-28 20:39 ` [PATCH 5/5] d80211: switch STA interfaces to PS mode during scan Michael Wu
2007-02-28 21:09   ` Jouni Malinen
2007-02-28 21:42     ` Michael Wu
2007-02-28 21:44       ` Michael Wu
2007-03-01  5:43         ` Michael Wu
2007-03-23 16:01           ` Jiri Benc
2007-03-23 18:05             ` Michael Wu
2007-03-23 19:01               ` Jiri Benc
2007-02-28 20:39 ` [PATCH 3/5] d80211: Set carrier status for STA interfaces Michael Wu
2007-03-21 17:25   ` Jiri Benc
2007-03-21 18:08     ` Michael Wu
2007-03-23 15:24       ` Jiri Benc
2007-02-28 20:39 ` Michael Wu [this message]
2007-03-01  2:14   ` [PATCH] d80211: Remove tx_timeout callback Michael Wu
2007-03-21 17:26     ` Jiri Benc
2007-02-28 20:39 ` [PATCH 4/5] d80211: Stop virtual interfaces during scan Michael Wu
2007-03-01  5:40   ` Michael Wu
2007-03-23 15:54     ` Jiri Benc
2007-03-01 17:00 ` [PATCH 1/5] d80211: Remove curr_rates and fix related concurrency issues Michael Wu
2007-03-21 17:22   ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228203943.11473.91707.stgit@magic.sourmilk.net \
    --to=flamingice@sourmilk.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.