From: Michael Wu <flamingice@sourmilk.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/5] d80211: switch STA interfaces to PS mode during scan
Date: Fri, 23 Mar 2007 14:05:15 -0400 [thread overview]
Message-ID: <200703231405.20085.flamingice@sourmilk.net> (raw)
In-Reply-To: <20070323170136.5f6205db@griffin.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Friday 23 March 2007 12:01, Jiri Benc wrote:
> > @@ -2541,10 +2572,12 @@ void ieee80211_scan_completed(struct iee
> >
> > spin_lock_bh(&local->sub_if_lock);
> > list_for_each_entry(sdata, &local->sub_if_list, list) {
> > - netif_wake_queue(sdata->dev);
> > -
> > - if (sdata->type == IEEE80211_IF_TYPE_STA)
> > + if (sdata->type == IEEE80211_IF_TYPE_STA) {
> > + if (sdata->u.sta.associated)
> > + ieee80211_send_nullfunc(local, sdata, 0);
> > ieee80211_sta_timer((unsigned long)&sdata->u.sta);
> > + }
> > + netif_wake_queue(sdata->dev);
>
> Shouldn't the queue be woken before calling ieee80211_sta_timer?
>
ieee80211_sta_timer just schedules the workqueue to run. I'm not sure if the
workqueue can run immediately after that, but even if it did, the sta code
doesn't depend on the queue of a virtual interface so these lines don't need
to run in any particular order.
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-03-23 18:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 20:39 [PATCH 1/5] d80211: Remove curr_rates and fix related concurrency issues Michael Wu
2007-02-28 20:39 ` [PATCH 5/5] d80211: switch STA interfaces to PS mode during scan Michael Wu
2007-02-28 21:09 ` Jouni Malinen
2007-02-28 21:42 ` Michael Wu
2007-02-28 21:44 ` Michael Wu
2007-03-01 5:43 ` Michael Wu
2007-03-23 16:01 ` Jiri Benc
2007-03-23 18:05 ` Michael Wu [this message]
2007-03-23 19:01 ` Jiri Benc
2007-02-28 20:39 ` [PATCH 3/5] d80211: Set carrier status for STA interfaces Michael Wu
2007-03-21 17:25 ` Jiri Benc
2007-03-21 18:08 ` Michael Wu
2007-03-23 15:24 ` Jiri Benc
2007-02-28 20:39 ` [PATCH 2/5] d80211: Do not require drivers to implement reset callback Michael Wu
2007-03-01 2:14 ` [PATCH] d80211: Remove tx_timeout callback Michael Wu
2007-03-21 17:26 ` Jiri Benc
2007-02-28 20:39 ` [PATCH 4/5] d80211: Stop virtual interfaces during scan Michael Wu
2007-03-01 5:40 ` Michael Wu
2007-03-23 15:54 ` Jiri Benc
2007-03-01 17:00 ` [PATCH 1/5] d80211: Remove curr_rates and fix related concurrency issues Michael Wu
2007-03-21 17:22 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703231405.20085.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.