All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Move eeprom_93cx6 from lib/ to drivers/misc/
@ 2007-03-21 10:37 Ivo van Doorn
  2007-03-21 15:34 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2007-03-21 10:37 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, Randy Dunlap, Andrew Morton

As requested, this will move the eeprom_93cx6 from its location in
lib/ to drivers/misc/

Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>

---

eeprom_93cx6.c was moved with:
cg-mv lib/eeprom_93cx6.c drivers/misc/eeprom_93cx6.c

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 80b199f..1af3e76 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -122,4 +122,12 @@ config SONY_LAPTOP
 
 	  Read <file:Documentation/sony-laptop.txt> for more information.
 
+config EEPROM_93CX6
+	tristate "EEPROM 93CX6 support"
+	  ---help---
+	  This is a driver for the EEPROM chipsets 93c46 and 93c66.
+	  The driver supports both read as well as write commands.
+
+	  When compiled as a module, this driver will be called "eeprom_93c6.ko".
+
 endmenu
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 7793ccd..f65b835 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -12,3 +12,4 @@ obj-$(CONFIG_TIFM_CORE)       	+= tifm_core.o
 obj-$(CONFIG_TIFM_7XX1)       	+= tifm_7xx1.o
 obj-$(CONFIG_SGI_IOC4)		+= ioc4.o
 obj-$(CONFIG_SONY_LAPTOP)	+= sony-laptop.o
+obj-$(CONFIG_EEPROM_93CX6)	+= eeprom_93cx6.o
diff --git a/lib/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
similarity index 100%
rename from lib/eeprom_93cx6.c
rename to drivers/misc/eeprom_93cx6.c
diff --git a/lib/Kconfig b/lib/Kconfig
index 0b275b7..8e91748 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -50,14 +50,6 @@ config LIBCRC32C
 	  require M here.  See Castagnoli93.
 	  Module will be libcrc32c.
 
-config EEPROM_93CX6
-	tristate "EEPROM 93CX6 support"
-	---help---
-	This is a driver for the EEPROM chipsets 93c46 and 93c66.
-	The driver supports both read as well as write commands.
-
-	When compiled as a module, this driver will be called "eeprom_93c6.ko".
-
 config AUDIT_GENERIC
 	bool
 	depends on AUDIT && !AUDIT_ARCH
diff --git a/lib/Makefile b/lib/Makefile
index 71ae5be..d7edaf3 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -56,8 +56,6 @@ obj-$(CONFIG_TEXTSEARCH_FSM) += ts_fsm.o
 obj-$(CONFIG_SMP) += percpu_counter.o
 obj-$(CONFIG_AUDIT_GENERIC) += audit.o
 
-obj-$(CONFIG_EEPROM_93CX6) += eeprom_93cx6.o
-
 obj-$(CONFIG_SWIOTLB) += swiotlb.o
 obj-$(CONFIG_FAULT_INJECTION) += fault-inject.o
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Move eeprom_93cx6 from lib/ to drivers/misc/
  2007-03-21 10:37 [PATCH] Move eeprom_93cx6 from lib/ to drivers/misc/ Ivo van Doorn
@ 2007-03-21 15:34 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2007-03-21 15:34 UTC (permalink / raw)
  To: Ivo van Doorn; +Cc: John Linville, linux-wireless, Andrew Morton

On Wed, 21 Mar 2007 11:37:50 +0100 Ivo van Doorn wrote:

> As requested, this will move the eeprom_93cx6 from its location in
> lib/ to drivers/misc/
> 
> Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>
> 
> ---
> 
> eeprom_93cx6.c was moved with:
> cg-mv lib/eeprom_93cx6.c drivers/misc/eeprom_93cx6.c
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 80b199f..1af3e76 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -122,4 +122,12 @@ config SONY_LAPTOP
>  
>  	  Read <file:Documentation/sony-laptop.txt> for more information.

Thanks.  Looks fine except this one little nit:
The "---help---" line should only be indented by one tab.
The text under it is indented correctly.

> +config EEPROM_93CX6
> +	tristate "EEPROM 93CX6 support"
> +	  ---help---
> +	  This is a driver for the EEPROM chipsets 93c46 and 93c66.
> +	  The driver supports both read as well as write commands.
> +
> +	  When compiled as a module, this driver will be called "eeprom_93c6.ko".
> +
>  endmenu
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 7793ccd..f65b835 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -12,3 +12,4 @@ obj-$(CONFIG_TIFM_CORE)       	+= tifm_core.o
>  obj-$(CONFIG_TIFM_7XX1)       	+= tifm_7xx1.o
>  obj-$(CONFIG_SGI_IOC4)		+= ioc4.o
>  obj-$(CONFIG_SONY_LAPTOP)	+= sony-laptop.o
> +obj-$(CONFIG_EEPROM_93CX6)	+= eeprom_93cx6.o
> diff --git a/lib/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
> similarity index 100%
> rename from lib/eeprom_93cx6.c
> rename to drivers/misc/eeprom_93cx6.c
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 0b275b7..8e91748 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -50,14 +50,6 @@ config LIBCRC32C
>  	  require M here.  See Castagnoli93.
>  	  Module will be libcrc32c.
>  
> -config EEPROM_93CX6
> -	tristate "EEPROM 93CX6 support"
> -	---help---
> -	This is a driver for the EEPROM chipsets 93c46 and 93c66.
> -	The driver supports both read as well as write commands.
> -
> -	When compiled as a module, this driver will be called "eeprom_93c6.ko".
> -
>  config AUDIT_GENERIC
>  	bool
>  	depends on AUDIT && !AUDIT_ARCH
> diff --git a/lib/Makefile b/lib/Makefile
> index 71ae5be..d7edaf3 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -56,8 +56,6 @@ obj-$(CONFIG_TEXTSEARCH_FSM) += ts_fsm.o
>  obj-$(CONFIG_SMP) += percpu_counter.o
>  obj-$(CONFIG_AUDIT_GENERIC) += audit.o
>  
> -obj-$(CONFIG_EEPROM_93CX6) += eeprom_93cx6.o
> -
>  obj-$(CONFIG_SWIOTLB) += swiotlb.o
>  obj-$(CONFIG_FAULT_INJECTION) += fault-inject.o
>  

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-21 15:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-21 10:37 [PATCH] Move eeprom_93cx6 from lib/ to drivers/misc/ Ivo van Doorn
2007-03-21 15:34 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.