From: Pavel Machek <pavel@ucw.cz>
To: David Brownell <david-b@pacbell.net>
Cc: linux-pm@lists.linux-foundation.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Victor <andrew@sanpeople.com>
Subject: Re: [linux-pm] [patch 2/2] clk_must_disable() implementation on AT91
Date: Fri, 23 Mar 2007 13:21:58 +0100 [thread overview]
Message-ID: <20070323122158.GE9667@elf.ucw.cz> (raw)
In-Reply-To: <200703221108.21861.david-b@pacbell.net>
Hi!
> This supports the new clk_must_disable() interface for AT91 systems:
>
> - Implement the call, replacing at91_suspend_entering_slow_clock()
> and eliminating various "that's not exported" build warnings;
>
> - Use it in three drivers: USB Host, USB Peripheral, and RS232 serial.
>
> Briefly, those are three of the drivers that need to act differently when
> going into deeper sleep states (suspend-to-RAM, vs standby), since among
> other things they can't act as wakeup event sources without using the
> clocks which are disabled in those deeper sleep states.
>
> (The at91_ethernet driver would be another such driver, but it doesn't
> currently implement wake-on-LAN even in the "standby" mode.)
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
FWIW, it looks okay to me. But you probably need to cc akpm if you
want it merged...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Victor <andrew@sanpeople.com>,
linux-pm@lists.linux-foundation.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/2] clk_must_disable() implementation on AT91
Date: Fri, 23 Mar 2007 13:21:58 +0100 [thread overview]
Message-ID: <20070323122158.GE9667@elf.ucw.cz> (raw)
In-Reply-To: <200703221108.21861.david-b@pacbell.net>
Hi!
> This supports the new clk_must_disable() interface for AT91 systems:
>
> - Implement the call, replacing at91_suspend_entering_slow_clock()
> and eliminating various "that's not exported" build warnings;
>
> - Use it in three drivers: USB Host, USB Peripheral, and RS232 serial.
>
> Briefly, those are three of the drivers that need to act differently when
> going into deeper sleep states (suspend-to-RAM, vs standby), since among
> other things they can't act as wakeup event sources without using the
> clocks which are disabled in those deeper sleep states.
>
> (The at91_ethernet driver would be another such driver, but it doesn't
> currently implement wake-on-LAN even in the "standby" mode.)
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
FWIW, it looks okay to me. But you probably need to cc akpm if you
want it merged...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-03-23 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 18:08 [patch 2/2] clk_must_disable() implementation on AT91 David Brownell
2007-03-23 12:21 ` Pavel Machek [this message]
2007-03-23 12:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323122158.GE9667@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=andrew@sanpeople.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.