All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben scott <benscott@nwlink.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: A bug in report.c? WAS: [linux-lvm] vg attributes (vg_attr) in vgs program don't seem to	match the man page
Date: Mon, 26 Mar 2007 15:47:20 -0700	[thread overview]
Message-ID: <200703261547.20641.benscott@nwlink.com> (raw)
In-Reply-To: <46078CE5.5050001@redhat.com>

On Monday 26 March 2007 02:05:41 am Milan Broz wrote:
>
> See lib/report/report.c in sources for exact description,
>
> Short overview
> (note that some attributes are used for hidden volumes only which are parts
> of snapshot, mirror, etc...)
>
> VG attributes
>
> wz--n-
>
> |||||`- clustered [c|-]
> ||||
> ||||`-- allocation policy
> |||| (c)ontiguous,(C)ling,(n)ormal,(a)nywhere,(i)nherit
> |||

<From the LVM2.2.02.24 source>
The following lines in report.c seems to show that (c) will become (C) if the 
lv is locked:

	repstr[2] = _alloc_policy_char(lv->alloc);

        	if (lv->status & LOCKED)
                	repstr[2] = toupper(repstr[2]);

That is also what the man page claims. However the start of report.c show 
this: 

 switch (alloc) {
        case ALLOC_CONTIGUOUS:
                return 'c';
        case ALLOC_CLING:
                return 'C';
        case ALLOC_NORMAL:
                return 'n';
        case ALLOC_ANYWHERE:
                return 'a';
        default:
                return 'i';
        }

Isn't that a conflict, or am I reading this wrong? BTW I am not a professional 
programmer nor do I play one on TV. 

  parent reply	other threads:[~2007-03-26 22:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26  0:11 [linux-lvm] vg attributes (vg_attr) in vgs program don't seem to match the man page ben scott
2007-03-26  9:05 ` Milan Broz
2007-03-26 18:38   ` ben scott
2007-03-26 18:51     ` Alasdair G Kergon
2007-03-26 22:47   ` ben scott [this message]
2007-03-27  1:00     ` A bug in report.c? WAS: " Jun'ichi Nomura
2007-03-27  6:48       ` [linux-lvm] LVM2 problem, volume group seems to dissapear Maciej Słojewski
2007-03-28 19:57         ` Dave Wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703261547.20641.benscott@nwlink.com \
    --to=benscott@nwlink.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.