All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: LVM general discussion and development <linux-lvm@redhat.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: A bug in report.c? WAS: [linux-lvm] vg attributes (vg_attr) in vgs program don't seem to match the man page
Date: Mon, 26 Mar 2007 21:00:29 -0400	[thread overview]
Message-ID: <46086CAD.2030402@ce.jp.nec.com> (raw)
In-Reply-To: <200703261547.20641.benscott@nwlink.com>

Hi,

ben scott wrote:
> The following lines in report.c seems to show that (c) will become (C) if the 
> lv is locked:
...
> That is also what the man page claims. However the start of report.c show 
> this: 
> 
>  switch (alloc) {
>         case ALLOC_CONTIGUOUS:
>                 return 'c';
>         case ALLOC_CLING:
>                 return 'C';
...
> Isn't that a conflict, or am I reading this wrong? BTW I am not a professional 
> programmer nor do I play one on TV. 

It's a bug.
I added the cling allocation policy and assigned 'C' to it
without checking the capitalization part of the report function...
Thanks for finding it.

Alasdair,
Sorry about this bug.
IMO, 'C' for ALLOC_CLING should be changed to other letter since it's
added after the capitalization.
It inevitably introduces possible compatibility issues for existing
user of attr field, however.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America

  reply	other threads:[~2007-03-27  1:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26  0:11 [linux-lvm] vg attributes (vg_attr) in vgs program don't seem to match the man page ben scott
2007-03-26  9:05 ` Milan Broz
2007-03-26 18:38   ` ben scott
2007-03-26 18:51     ` Alasdair G Kergon
2007-03-26 22:47   ` A bug in report.c? WAS: " ben scott
2007-03-27  1:00     ` Jun'ichi Nomura [this message]
2007-03-27  6:48       ` [linux-lvm] LVM2 problem, volume group seems to dissapear Maciej Słojewski
2007-03-28 19:57         ` Dave Wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46086CAD.2030402@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=agk@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.