Re: [PATCH 3/8] Use process freezer for cpu-hotplug

From: Nathan Lynch <ntl@pobox.com>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: akpm@linux-foundation.org, paulmck@us.ibm.com,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	vatsa@in.ibm.com, Oleg Nesterov <oleg@tv-sign.ru>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	mingo@elte.hu, dipankar@in.ibm.com, dino@in.ibm.com,
	masami.hiramatsu.pt@hitachi.com
Subject: Re: [PATCH 3/8] Use process freezer for cpu-hotplug
Date: Fri, 6 Apr 2007 12:27:14 -0500	[thread overview]
Message-ID: <20070406172714.GA6131@localdomain> (raw)
In-Reply-To: <20070402053824.GC12962@in.ibm.com>

Gautham R Shenoy wrote:
> This patch implements process_freezer based cpu-hotplug
> core. 
> The sailent features are:
> o No more (un)lock_cpu_hotplug.
> o No more CPU_LOCK_ACQUIRE and CPU_LOCK_RELEASE. Hence no per-subsystem
>   hotcpu mutexes.
> o Calls freeze_process/thaw_processes at the beginning/end of
>   the hotplug operation.

...

> @@ -133,7 +111,11 @@ static int _cpu_down(unsigned int cpu)
>  	if (!cpu_online(cpu))
>  		return -EINVAL;
>  
> -	raw_notifier_call_chain(&cpu_chain, CPU_LOCK_ACQUIRE, hcpu);
> +	if (freeze_processes(FE_HOTPLUG_CPU)) {
> +		thaw_processes(FE_HOTPLUG_CPU);
> +		return -EBUSY;
> +	}
> +

If I'm understanding correctly, this will cause

# echo 0 > /sys/devices/system/cpu/cpuX/online

to sometimes fail, and userspace is expected to try again?  This will
break existing applications.

Perhaps drivers/base/cpu.c:store_online should retry as long as
cpu_up/down return -EBUSY.  That would avoid a userspace-visible
interface change.