[PATCH] zap_other_threads: remove unneeded ->exit_signal change

[PATCH] zap_other_threads: remove unneeded ->exit_signal change

[Oleg Nesterov]

We already depend on fact that all sub-threads have ->exit_signal == -1,
no need to set it in zap_other_threads().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 2.6.21-rc5-mm4/kernel/signal.c~zat	2007-04-07 20:11:14.000000000 +0400
+++ 2.6.21-rc5-mm4/kernel/signal.c	2007-04-08 22:09:20.000000000 +0400
@@ -1163,17 +1163,6 @@ void zap_other_threads(struct task_struc
 		if (t->exit_state)
 			continue;
 
-		/*
-		 * We don't want to notify the parent, since we are
-		 * killed as part of a thread group due to another
-		 * thread doing an execve() or similar. So set the
-		 * exit signal to -1 to allow immediate reaping of
-		 * the process.  But don't detach the thread group
-		 * leader.
-		 */
-		if (t != p->group_leader)
-			t->exit_signal = -1;
-
 		/* SIGKILL will be handled before any pending SIGSTOP */
 		sigaddset(&t->pending.signal, SIGKILL);
 		signal_wake_up(t, 1);

Re: [PATCH] zap_other_threads: remove unneeded ->exit_signal change

[Roland McGrath]

I think that's correct.


Thanks,
Roland