All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wu <flamingice@sourmilk.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	John Linville <linville@tuxdriver.com>,
	Andrea Merello <andrea.merello@gmail.com>
Subject: Re: [PATCH v2] Add rtl8187 wireless driver
Date: Mon, 7 May 2007 19:17:20 -0400	[thread overview]
Message-ID: <200705071917.25414.flamingice@sourmilk.net> (raw)
In-Reply-To: <463F44E6.5030705@garzik.org>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Monday 07 May 2007 11:25, Jeff Garzik wrote:
> I am a bit skeptical that multiple files are needed.  It seems like
> drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c.
>
The radio tuning stuff could be stuffed into rtl8187_dev.c, but I like to keep 
it separate since rtl8187_rtl8225.c tends to contain all the radio tuning 
black magic that no one really understands except for the engineers at 
Realtek, whereas rtl8187_dev.c is mostly straightforward. rtl8187 can also 
(in theory) use another radio chip (rtl8255). The two headers - rtl818x.h and 
rtl8187.h cannot be merged because the definitions in rtl818x.h are shared 
between the usb and pci drivers.

I rather not combine any files, though I don't mind collapsing the driver 
another level. However, I think other driver authors much prefer having their 
own directory, and I'd like to keep the drivers consistently in their own 
directory or all together in drivers/net/wireless.

-Michael Wu

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Michael Wu <flamingice-R9e9/4HEdknk1uMJSBkQmQ@public.gmane.org>
To: Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	Andrea Merello
	<andrea.merello-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] Add rtl8187 wireless driver
Date: Mon, 7 May 2007 19:17:20 -0400	[thread overview]
Message-ID: <200705071917.25414.flamingice@sourmilk.net> (raw)
In-Reply-To: <463F44E6.5030705-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Monday 07 May 2007 11:25, Jeff Garzik wrote:
> I am a bit skeptical that multiple files are needed.  It seems like
> drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c.
>
The radio tuning stuff could be stuffed into rtl8187_dev.c, but I like to keep 
it separate since rtl8187_rtl8225.c tends to contain all the radio tuning 
black magic that no one really understands except for the engineers at 
Realtek, whereas rtl8187_dev.c is mostly straightforward. rtl8187 can also 
(in theory) use another radio chip (rtl8255). The two headers - rtl818x.h and 
rtl8187.h cannot be merged because the definitions in rtl818x.h are shared 
between the usb and pci drivers.

I rather not combine any files, though I don't mind collapsing the driver 
another level. However, I think other driver authors much prefer having their 
own directory, and I'd like to keep the drivers consistently in their own 
directory or all together in drivers/net/wireless.

-Michael Wu

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-05-07 23:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 14:22 [PATCH v2] Add rtl8187 wireless driver Michael Wu
2007-05-07 15:25 ` Jeff Garzik
2007-05-07 15:25   ` Jeff Garzik
2007-05-07 23:17   ` Michael Wu [this message]
2007-05-07 23:17     ` Michael Wu
2007-05-07 23:25     ` David Miller
2007-05-08  0:03       ` Michael Wu
2007-05-08  0:03         ` Michael Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705071917.25414.flamingice@sourmilk.net \
    --to=flamingice@sourmilk.net \
    --cc=andrea.merello@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.