All of lore.kernel.org
 help / color / mirror / Atom feed
* + knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc.patch added to -mm tree
@ 2007-05-07 23:08 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-05-07 23:08 UTC (permalink / raw)
  To: mm-commits; +Cc: yjwei, bfields, neilb


The patch titled
     knfsd: rpcgss: RPC_GSS_PROC_ DESTROY request will get a bad rpc
has been added to the -mm tree.  Its filename is
     knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: knfsd: rpcgss: RPC_GSS_PROC_ DESTROY request will get a bad rpc
From: Wei Yongjun <yjwei@cn.fujitsu.com>

If I send a RPC_GSS_PROC_DESTROY message to NFSv4 server, it will reply with a
bad rpc reply which lacks an authentication verifier.  Maybe this patch is
needed.

Send/recv packets as following:

send:

RemoteProcedureCall
    xid
    rpcvers = 2
    prog = 100003
    vers = 4
    proc = 0
    cred = AUTH_GSS
        version = 1
        gss_proc = 3 (RPCSEC_GSS_DESTROY)
        service  = 1 (RPC_GSS_SVC_NONE)
    verf = AUTH_GSS
        checksum

reply:

RemoteProcedureReply
    xid
    msg_type
    reply_stat
    accepted_reply

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/auth_gss/svcauth_gss.c |    2 ++
 1 files changed, 2 insertions(+)

diff -puN net/sunrpc/auth_gss/svcauth_gss.c~knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc net/sunrpc/auth_gss/svcauth_gss.c
--- a/net/sunrpc/auth_gss/svcauth_gss.c~knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc
+++ a/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1106,6 +1106,8 @@ svcauth_gss_accept(struct svc_rqst *rqst
 		}
 		goto complete;
 	case RPC_GSS_PROC_DESTROY:
+		if (gss_write_verf(rqstp, rsci->mechctx, gc->gc_seq))
+			goto auth_err;
 		set_bit(CACHE_NEGATIVE, &rsci->h.flags);
 		if (resv->iov_len + 4 > PAGE_SIZE)
 			goto drop;
_

Patches currently in -mm which might be from yjwei@cn.fujitsu.com are

knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-05-07 23:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-07 23:08 + knfsd-rpcgss-rpc_gss_proc_-destroy-request-will-get-a-bad-rpc.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.