* - slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes.patch removed from -mm tree
@ 2007-05-08 0:08 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2007-05-08 0:08 UTC (permalink / raw)
To: clameter, mm-commits
The patch titled
SLUB: allocate smallest object size if the user asks for 0 bytes
has been removed from the -mm tree. Its filename was
slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: SLUB: allocate smallest object size if the user asks for 0 bytes
From: Christoph Lameter <clameter@sgi.com>
Makes SLUB behave like SLAB in this area to avoid issues....
Throw a stack dump to alert people.
At some point the behavior should be switched back. NULL is no memory as
far as I can tell and if the use asked for 0 bytes then he need to get no
memory.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/slub_def.h | 8 ++++++--
mm/slub.c | 2 +-
2 files changed, 7 insertions(+), 3 deletions(-)
diff -puN include/linux/slub_def.h~slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes include/linux/slub_def.h
--- a/include/linux/slub_def.h~slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes
+++ a/include/linux/slub_def.h
@@ -80,8 +80,12 @@ extern struct kmem_cache kmalloc_caches[
*/
static inline int kmalloc_index(int size)
{
- if (size == 0)
- return 0;
+ /*
+ * We should return 0 if size == 0 but we use the smallest object
+ * here for SLAB legacy reasons.
+ */
+ WARN_ON_ONCE(size == 0);
+
if (size > 64 && size <= 96)
return 1;
if (size > 128 && size <= 192)
diff -puN mm/slub.c~slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes mm/slub.c
--- a/mm/slub.c~slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes
+++ a/mm/slub.c
@@ -1979,7 +1979,7 @@ static struct kmem_cache *get_slab(size_
{
int index = kmalloc_index(size);
- if (!size)
+ if (!index)
return NULL;
/* Allocation too large? */
_
Patches currently in -mm which might be from clameter@sgi.com are
origin.patch
quicklist-support-for-ia64.patch
quicklist-support-for-x86_64.patch
slub-exploit-page-mobility-to-increase-allocation-order.patch
slub-mm-only-make-slub-the-default-slab-allocator.patch
slub-i386-support.patch
remove-constructor-from-buffer_head.patch
slab-shutdown-cache_reaper-when-cpu-goes-down.patch
mm-implement-swap-prefetching.patch
revoke-core-code-slab-allocators-remove-slab_debug_initial-flag-revoke.patch
vmstat-use-our-own-timer-events.patch
make-vm-statistics-update-interval-configurable.patch
make-vm-statistics-update-interval-configurable-fix.patch
readahead-state-based-method-aging-accounting.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-08 0:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-08 0:08 - slub-allocate-smallest-object-size-if-the-user-asks-for-0-bytes.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.