* - document-spin_lock_unlocked-rw_lock_unlocked-deprecation.patch removed from -mm tree
@ 2007-05-09 2:50 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2007-05-09 2:50 UTC (permalink / raw)
To: michael, mingo, mm-commits
The patch titled
Document SPIN_LOCK_UNLOCKED/RW_LOCK_UNLOCKED deprecation
has been removed from the -mm tree. Its filename was
document-spin_lock_unlocked-rw_lock_unlocked-deprecation.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: Document SPIN_LOCK_UNLOCKED/RW_LOCK_UNLOCKED deprecation
From: Michael Ellerman <michael@ellerman.id.au>
Apparently it's not cool anymore to use SPIN/RW_LOCK_UNLOCKED. There's
some mention of this in Documentation/spinlocks.txt, but that only talks
about dynamic initialisation.
A comment in the code mentioning the preferred usage would be good IMHO.
[akpm@linux-foundation.org: add reason for deprecation]
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/spinlock_types.h | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN include/linux/spinlock_types.h~document-spin_lock_unlocked-rw_lock_unlocked-deprecation include/linux/spinlock_types.h
--- a/include/linux/spinlock_types.h~document-spin_lock_unlocked-rw_lock_unlocked-deprecation
+++ a/include/linux/spinlock_types.h
@@ -85,6 +85,12 @@ typedef struct {
RW_DEP_MAP_INIT(lockname) }
#endif
+/*
+ * SPIN_LOCK_UNLOCKED and RW_LOCK_UNLOCKED defeat lockdep state tracking and
+ * are hence deprecated.
+ * Please use DEFINE_SPINLOCK()/DEFINE_RWLOCK() or
+ * __SPIN_LOCK_UNLOCKED()/__RW_LOCK_UNLOCKED() as appropriate.
+ */
#define SPIN_LOCK_UNLOCKED __SPIN_LOCK_UNLOCKED(old_style_spin_init)
#define RW_LOCK_UNLOCKED __RW_LOCK_UNLOCKED(old_style_rw_init)
_
Patches currently in -mm which might be from michael@ellerman.id.au are
origin.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-09 2:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-09 2:50 - document-spin_lock_unlocked-rw_lock_unlocked-deprecation.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.