All of lore.kernel.org
 help / color / mirror / Atom feed
* + serial-set-dtr-in-uart-for-kernel-serial-console.patch added to -mm tree
@ 2007-05-17 18:33 akpm
  0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2007-05-17 18:33 UTC (permalink / raw)
  To: mm-commits; +Cc: Yinghai.Lu, ak, bjorn.helgaas, rmk, yinghai.lu


The patch titled
     serial: set DTR in uart for kernel serial console
has been added to the -mm tree.  Its filename is
     serial-set-dtr-in-uart-for-kernel-serial-console.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: serial: set DTR in uart for kernel serial console
From: Yinghai Lu <Yinghai.Lu@Sun.COM>

Some UARTs on other side need host uart DTR is set, otherwise will not
receive char from the host that kernel is runing during kernel boot stage.

BTW: earlyprintk and early_uart are hard coded to set DTR/RTS.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andi Kleen <ak@suse.de>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/8250.c |    5 +++++
 1 files changed, 5 insertions(+)

diff -puN drivers/serial/8250.c~serial-set-dtr-in-uart-for-kernel-serial-console drivers/serial/8250.c
--- a/drivers/serial/8250.c~serial-set-dtr-in-uart-for-kernel-serial-console
+++ a/drivers/serial/8250.c
@@ -2397,6 +2397,11 @@ static void __init serial8250_isa_init_p
 		up->mcr_force = ALPHA_KLUDGE_MCR;
 
 		up->port.ops = &serial8250_pops;
+
+		/* some uarts on other side don't support no flow control. So we set
+		 * DTR in host uart to make them happy  --- YHLU
+		 */
+		up->port.mctrl |= TIOCM_DTR;
 	}
 
 	for (i = 0, up = serial8250_ports;
_

Patches currently in -mm which might be from Yinghai.Lu@Sun.COM are

serial-set-dtr-in-uart-for-kernel-serial-console.patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* + serial-set-dtr-in-uart-for-kernel-serial-console.patch added to -mm tree
@ 2007-05-30 20:50 akpm
  0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2007-05-30 20:50 UTC (permalink / raw)
  To: mm-commits; +Cc: Yinghai.Lu, ak, bjorn.helgaas, rmk, yinghai.lu


The patch titled
     serial: set DTR in uart for kernel serial console
has been added to the -mm tree.  Its filename is
     serial-set-dtr-in-uart-for-kernel-serial-console.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: serial: set DTR in uart for kernel serial console
From: Yinghai Lu <Yinghai.Lu@Sun.COM>

Some RS-232 devices require DTR to be asserted before they can be used.  DTR
is normally asserted in uart_startup() when the port is opened.  But we don't
actually open serial console ports, so assert DTR when the port is added.

BTW:
earlyprintk and early_uart are hard coded to set DTR/RTS.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andi Kleen <ak@suse.de>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/serial_core.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletion(-)

diff -puN drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console drivers/serial/serial_core.c
--- a/drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console
+++ a/drivers/serial/serial_core.c
@@ -2303,8 +2303,14 @@ int uart_add_one_port(struct uart_driver
 	 * It may be that the port was not available.
 	 */
 	if (port->type != PORT_UNKNOWN &&
-	    port->cons && !(port->cons->flags & CON_ENABLED))
+	    port->cons && !(port->cons->flags & CON_ENABLED)) {
+		/*
+		 * We normally assert DTR when a port is opened, but serial
+		 * console devices aren't actually opened, so do it here.
+		 */
+		uart_set_mctrl(port, TIOCM_DTR);
 		register_console(port->cons);
+	}
 
 	/*
 	 * Ensure UPF_DEAD is not set.
_

Patches currently in -mm which might be from Yinghai.Lu@Sun.COM are

console-more-buf-for-index-parsing.patch
console-console-handover-to-preferred-console.patch
serial-convert-early_uart-to-earlycon-for-8250.patch
serial-set-dtr-in-uart-for-kernel-serial-console.patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* + serial-set-dtr-in-uart-for-kernel-serial-console.patch added to -mm tree
@ 2007-05-30 19:00 akpm
  0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2007-05-30 19:00 UTC (permalink / raw)
  To: mm-commits; +Cc: Yinghai.Lu, ak, bjorn.helgaas, rmk, yinghai.lu


The patch titled
     serial: set DTR in uart for kernel serial console
has been added to the -mm tree.  Its filename is
     serial-set-dtr-in-uart-for-kernel-serial-console.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: serial: set DTR in uart for kernel serial console
From: Yinghai Lu <Yinghai.Lu@Sun.COM>

Some UARTs on other side need host uart DTR is set, otherwise will not
receive char from the host that kernel is runing during kernel boot stage.

BTW:
earlyprintk and early_uart are hard coded to set DTR/RTS.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andi Kleen <ak@suse.de>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/serial_core.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletion(-)

diff -puN drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console drivers/serial/serial_core.c
--- a/drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console
+++ a/drivers/serial/serial_core.c
@@ -2303,8 +2303,14 @@ int uart_add_one_port(struct uart_driver
 	 * It may be that the port was not available.
 	 */
 	if (port->type != PORT_UNKNOWN &&
-	    port->cons && !(port->cons->flags & CON_ENABLED))
+	    port->cons && !(port->cons->flags & CON_ENABLED)) {
+		/*
+		 * some uarts on other side don't support no flow control.
+		 * So we set DTR in host uart to make them happy  --- YHLU
+		 */
+		port->mctrl |= TIOCM_DTR;
 		register_console(port->cons);
+	}
 
 	/*
 	 * Ensure UPF_DEAD is not set.
_

Patches currently in -mm which might be from Yinghai.Lu@Sun.COM are

console-more-buf-for-index-parsing.patch
console-console-handover-to-preferred-console.patch
serial-convert-early_uart-to-earlycon-for-8250.patch
serial-set-dtr-in-uart-for-kernel-serial-console.patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* + serial-set-dtr-in-uart-for-kernel-serial-console.patch added to -mm tree
@ 2007-05-29 19:41 akpm
  0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2007-05-29 19:41 UTC (permalink / raw)
  To: mm-commits; +Cc: Yinghai.Lu, ak, bjorn.helgaas, rmk, yinghai.lu


The patch titled
     serial: set DTR in uart for kernel serial console
has been added to the -mm tree.  Its filename is
     serial-set-dtr-in-uart-for-kernel-serial-console.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: serial: set DTR in uart for kernel serial console
From: Yinghai Lu <Yinghai.Lu@Sun.COM>

Some UARTs on other side need host uart DTR is set, otherwise will not
receive char from the host that kernel is runing during kernel boot stage.

BTW:
earlyprintk and early_uart are hard coded to set DTR/RTS.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andi Kleen <ak@suse.de>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/serial_core.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)

diff -puN drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console drivers/serial/serial_core.c
--- a/drivers/serial/serial_core.c~serial-set-dtr-in-uart-for-kernel-serial-console
+++ a/drivers/serial/serial_core.c
@@ -2304,8 +2304,13 @@ int uart_add_one_port(struct uart_driver
 	 * It may be that the port was not available.
 	 */
 	if (port->type != PORT_UNKNOWN &&
-	    port->cons && !(port->cons->flags & CON_ENABLED))
+	    port->cons && !(port->cons->flags & CON_ENABLED)) {
+		/* some uarts on other side don't support no flow control. So we set
+		 * DTR in host uart to make them happy  --- YHLU
+		 */
+		port->mctrl |= TIOCM_DTR;
 		register_console(port->cons);
+	}
 
 	/*
 	 * Ensure UPF_DEAD is not set.
_

Patches currently in -mm which might be from Yinghai.Lu@Sun.COM are

serial-set-dtr-in-uart-for-kernel-serial-console.patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-05-30 20:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-17 18:33 + serial-set-dtr-in-uart-for-kernel-serial-console.patch added to -mm tree akpm
2007-05-29 19:41 akpm
2007-05-30 19:00 akpm
2007-05-30 20:50 akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.