All of lore.kernel.org
 help / color / mirror / Atom feed
* + rtc-m48t59-driver-no_irq-mode-fixup.patch added to -mm tree
@ 2007-07-25  2:37 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-07-25  2:37 UTC (permalink / raw)
  To: mm-commits; +Cc: rongkai.zhan, a.zummo


The patch titled
     rtc-m48t59 driver NO_IRQ mode fixup
has been added to the -mm tree.  Its filename is
     rtc-m48t59-driver-no_irq-mode-fixup.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: rtc-m48t59 driver NO_IRQ mode fixup
From: Mark Zhan <rongkai.zhan@windriver.com>

Since irq in m48t59_private struct is defined as 'unsigned int', which will
make the following if sentence to be never true:

         if (m48t59->irq < 0)
                  m48t59->irq = NO_IRQ;

And thus it will make the m48t59_rtc_probe() is failed when the driver is
working in a no irq mode:

Signed-off-by: Mark Zhan <rongkai.zhan@windriver.com>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/rtc/rtc-m48t59.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/rtc/rtc-m48t59.c~rtc-m48t59-driver-no_irq-mode-fixup drivers/rtc/rtc-m48t59.c
--- a/drivers/rtc/rtc-m48t59.c~rtc-m48t59-driver-no_irq-mode-fixup
+++ a/drivers/rtc/rtc-m48t59.c
@@ -35,7 +35,7 @@
 struct m48t59_private {
 	void __iomem *ioaddr;
 	unsigned int size; /* iomem size */
-	unsigned int irq;
+	int irq;
 	struct rtc_device *rtc;
 	spinlock_t lock; /* serialize the NVRAM and RTC access */
 };
_

Patches currently in -mm which might be from rongkai.zhan@windriver.com are

no-need-to-convert-file-private_data-to-rtc-device.patch
rtc-m48t59-driver-no_irq-mode-fixup.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-25  2:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-25  2:37 + rtc-m48t59-driver-no_irq-mode-fixup.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.