All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 5/6] mptlan: bug fix, only half the message frame is dma'd resulting in corruption
@ 2007-09-29 16:17 Eric Moore
  0 siblings, 0 replies; only message in thread
From: Eric Moore @ 2007-09-29 16:17 UTC (permalink / raw)
  To: linux-scsi, James.Bottomley

NB = number of blocks.  This represents the number of blocks to transfer.
The block size is based on the message frame size provided in the ioc_facts. A value of zero indicates the entire message frame should be copied. This is two bit value.  So by setting this to non-zero vaule, you increase performance by reducing amount of data needing to be dma'd.   The value that is stored in ioc->ReqeustNB is sometimes a non-zero vaule, which  creates a bug in mptlan, where not the entire message frame is getting transfer to firware, resulting in corruption.  This fix sets the default to zero, thus entire message frame is copied.


Signed-off-by: Eric Moore <Eric.Moore@lsi.com>

diff -uarpN b/drivers/message/fusion/mptlan.c a/drivers/message/fusion/mptlan.c
--- b/drivers/message/fusion/mptlan.c	2007-09-17 17:17:50.000000000 -0600
+++ a/drivers/message/fusion/mptlan.c	2007-09-28 17:36:04.000000000 -0600
@@ -1224,6 +1224,8 @@ mpt_lan_post_receive_buckets(struct mpt_
 		}
 		pRecvReq = (LANReceivePostRequest_t *) mf;
 
+		i = le16_to_cpu(mf->u.frame.hwhdr.msgctxu.fld.req_idx);
+		mpt_dev->RequestNB[i] = 0;
 		count = buckets;
 		if (count > max)
 			count = max;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-09-29 16:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-29 16:17 [PATCH 5/6] mptlan: bug fix, only half the message frame is dma'd resulting in corruption Eric Moore

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.