* [PATCH] JFS: Bio cleanup: Replace missing return statements
@ 2007-10-13 19:11 Jeff Garzik
2007-10-13 19:28 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-10-13 19:11 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: LKML, shaggy
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
statements, rather than changing them to null returns.
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
Dave sent this under a different cover, but just in case it was missed
in the middle of the thread, I wanted to make sure it was not missed.
fs/jfs/jfs_logmgr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index ccfd029..15a3974 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
/* wakeup I/O initiator */
LCACHE_WAKEUP(&bp->l_ioevent);
+
+ return;
}
/*
@@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
if (bp->l_flag & lbmDIRECT) {
LCACHE_WAKEUP(&bp->l_ioevent);
LCACHE_UNLOCK(flags);
+ return;
}
tail = log->wqueue;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
2007-10-13 19:11 [PATCH] JFS: Bio cleanup: Replace missing return statements Jeff Garzik
@ 2007-10-13 19:28 ` Randy Dunlap
2007-10-14 1:46 ` Dave Kleikamp
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2007-10-13 19:28 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Linus Torvalds, LKML, shaggy
On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:
>
> From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
>
> commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
> statements, rather than changing them to null returns.
Is my git tree mucked up? It looks to me like it was commit
e30408b2a99cb7b8bf529c7dc2328a19d71894cf that removed the return 0's.
> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> Dave sent this under a different cover, but just in case it was missed
> in the middle of the thread, I wanted to make sure it was not missed.
>
> fs/jfs/jfs_logmgr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index ccfd029..15a3974 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
>
> /* wakeup I/O initiator */
> LCACHE_WAKEUP(&bp->l_ioevent);
> +
> + return;
> }
>
> /*
> @@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
> if (bp->l_flag & lbmDIRECT) {
> LCACHE_WAKEUP(&bp->l_ioevent);
> LCACHE_UNLOCK(flags);
> + return;
> }
>
> tail = log->wqueue;
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
2007-10-13 19:28 ` Randy Dunlap
@ 2007-10-14 1:46 ` Dave Kleikamp
0 siblings, 0 replies; 3+ messages in thread
From: Dave Kleikamp @ 2007-10-14 1:46 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Jeff Garzik, Andrew Morton, Linus Torvalds, LKML
On Sat, 2007-10-13 at 12:28 -0700, Randy Dunlap wrote:
> On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:
>
> >
> > From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> >
> > commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
> > statements, rather than changing them to null returns.
>
> Is my git tree mucked up? It looks to me like it was commit
> e30408b2a99cb7b8bf529c7dc2328a19d71894cf that removed the return 0's.
Yeah. It was that one. I cut and pasted the wrong one for the comment.
Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-14 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-13 19:11 [PATCH] JFS: Bio cleanup: Replace missing return statements Jeff Garzik
2007-10-13 19:28 ` Randy Dunlap
2007-10-14 1:46 ` Dave Kleikamp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.