* [PATCH] drivers/block/cpqarray,cciss: kill unused var
@ 2007-10-13 19:03 Jeff Garzik
2007-10-15 7:52 ` Jens Axboe
2007-10-16 14:55 ` Miller, Mike (OS Dev)
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-10-13 19:03 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: LKML, jens.axboe, iss_storagedev
The recent bio work and subsequent fixups created unused variables.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
drivers/block/cciss.c | 1 -
drivers/block/cpqarray.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 28d1457..27401d6 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1191,7 +1191,6 @@ static inline void complete_buffers(struct bio *bio, int status)
{
while (bio) {
struct bio *xbh = bio->bi_next;
- int nr_sectors = bio_sectors(bio);
bio->bi_next = NULL;
bio_endio(bio, status ? 0 : -EIO);
diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 3853c9a..568603d 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)
static inline void complete_buffers(struct bio *bio, int ok)
{
struct bio *xbh;
- while(bio) {
- int nr_sectors = bio_sectors(bio);
+ while (bio) {
xbh = bio->bi_next;
bio->bi_next = NULL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/block/cpqarray,cciss: kill unused var
2007-10-13 19:03 [PATCH] drivers/block/cpqarray,cciss: kill unused var Jeff Garzik
@ 2007-10-15 7:52 ` Jens Axboe
2007-10-16 14:55 ` Miller, Mike (OS Dev)
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2007-10-15 7:52 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Linus Torvalds, LKML, iss_storagedev
On Sat, Oct 13 2007, Jeff Garzik wrote:
> The recent bio work and subsequent fixups created unused variables.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> drivers/block/cciss.c | 1 -
> drivers/block/cpqarray.c | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
Thanks Jeff, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drivers/block/cpqarray,cciss: kill unused var
2007-10-13 19:03 [PATCH] drivers/block/cpqarray,cciss: kill unused var Jeff Garzik
2007-10-15 7:52 ` Jens Axboe
@ 2007-10-16 14:55 ` Miller, Mike (OS Dev)
1 sibling, 0 replies; 3+ messages in thread
From: Miller, Mike (OS Dev) @ 2007-10-16 14:55 UTC (permalink / raw)
To: Jeff Garzik, Andrew Morton, Linus Torvalds
Cc: LKML, jens.axboe, ISS StorageDev
> -----Original Message-----
> From: Jeff Garzik [mailto:jeff@garzik.org]
> Sent: Saturday, October 13, 2007 2:04 PM
> To: Andrew Morton; Linus Torvalds
> Cc: LKML; jens.axboe@oracle.com; ISS StorageDev
> Subject: [PATCH] drivers/block/cpqarray,cciss: kill unused var
>
> The recent bio work and subsequent fixups created unused variables.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Acked-by: Mike Miller <mike.miller@hp.com>
> ---
> drivers/block/cciss.c | 1 -
> drivers/block/cpqarray.c | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 28d1457..27401d6 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1191,7 +1191,6 @@ static inline void
> complete_buffers(struct bio *bio, int status) {
> while (bio) {
> struct bio *xbh = bio->bi_next;
> - int nr_sectors = bio_sectors(bio);
>
> bio->bi_next = NULL;
> bio_endio(bio, status ? 0 : -EIO);
> diff --git a/drivers/block/cpqarray.c
> b/drivers/block/cpqarray.c index 3853c9a..568603d 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)
> static inline void complete_buffers(struct bio *bio, int ok) {
> struct bio *xbh;
> - while(bio) {
> - int nr_sectors = bio_sectors(bio);
>
> + while (bio) {
> xbh = bio->bi_next;
> bio->bi_next = NULL;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-16 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-13 19:03 [PATCH] drivers/block/cpqarray,cciss: kill unused var Jeff Garzik
2007-10-15 7:52 ` Jens Axboe
2007-10-16 14:55 ` Miller, Mike (OS Dev)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.