* [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c
@ 2007-12-04 19:30 rohara
0 siblings, 0 replies; 4+ messages in thread
From: rohara @ 2007-12-04 19:30 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rohara at sourceware.org 2007-12-04 19:30:27
Modified files:
gfs-kernel/src/gfs: eaops.c
Log message:
BZ 323111
Remove permission() checks from xattrs ops.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/eaops.c.diff?cvsroot=cluster&r1=1.6&r2=1.7
--- cluster/gfs-kernel/src/gfs/eaops.c 2006/07/17 21:38:13 1.6
+++ cluster/gfs-kernel/src/gfs/eaops.c 2007/12/04 19:30:27 1.7
@@ -71,13 +71,6 @@
static int
user_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
- }
-
return gfs_ea_get_i(ip, er);
}
@@ -92,17 +85,6 @@
static int
user_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_set_i(ip, er);
}
@@ -117,17 +99,6 @@
static int
user_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_remove_i(ip, er);
}
@@ -238,11 +209,6 @@
static int
security_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
-
return gfs_ea_get_i(ip, er);
}
@@ -257,11 +223,6 @@
static int
security_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_set_i(ip, er);
}
@@ -276,11 +237,6 @@
static int
security_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_remove_i(ip, er);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c
@ 2008-01-30 8:32 fabbione
0 siblings, 0 replies; 4+ messages in thread
From: fabbione @ 2008-01-30 8:32 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: fabbione at sourceware.org 2008-01-30 08:32:40
Modified files:
gfs-kernel/src/gfs: eaops.c
Log message:
Remove unrequire functions. This follow gfs2 changes
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/eaops.c.diff?cvsroot=cluster&r1=1.8&r2=1.9
--- cluster/gfs-kernel/src/gfs/eaops.c 2008/01/30 06:37:53 1.8
+++ cluster/gfs-kernel/src/gfs/eaops.c 2008/01/30 08:32:28 1.9
@@ -61,48 +61,6 @@
}
/**
- * user_eo_get -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-user_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_get_i(ip, er);
-}
-
-/**
- * user_eo_set -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-user_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_set_i(ip, er);
-}
-
-/**
- * user_eo_remove -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-user_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_remove_i(ip, er);
-}
-
-/**
* system_eo_get -
* @ip:
* @er:
@@ -198,52 +156,10 @@
return gfs_ea_remove_i(ip, er);
}
-/**
- * security_eo_get -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-security_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_get_i(ip, er);
-}
-
-/**
- * security_eo_set -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-security_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_set_i(ip, er);
-}
-
-/**
- * security_eo_remove -
- * @ip:
- * @er:
- *
- * Returns: errno
- */
-
-static int
-security_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
-{
- return gfs_ea_remove_i(ip, er);
-}
-
struct gfs_eattr_operations gfs_user_eaops = {
- .eo_get = user_eo_get,
- .eo_set = user_eo_set,
- .eo_remove = user_eo_remove,
+ .eo_get = gfs_ea_get_i,
+ .eo_set = gfs_ea_set_i,
+ .eo_remove = gfs_ea_remove_i,
.eo_name = "user",
};
@@ -255,9 +171,9 @@
};
struct gfs_eattr_operations gfs_security_eaops = {
- .eo_get = security_eo_get,
- .eo_set = security_eo_set,
- .eo_remove = security_eo_remove,
+ .eo_get = gfs_ea_get_i,
+ .eo_set = gfs_ea_set_i,
+ .eo_remove = gfs_ea_remove_i,
.eo_name = "security",
};
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c
@ 2007-12-04 19:28 rohara
0 siblings, 0 replies; 4+ messages in thread
From: rohara @ 2007-12-04 19:28 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: rohara at sourceware.org 2007-12-04 19:28:55
Modified files:
gfs-kernel/src/gfs: eaops.c
Log message:
BZ 323111
Remove permission() checks from xattr ops.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/eaops.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.6&r2=1.6.2.1
--- cluster/gfs-kernel/src/gfs/eaops.c 2006/07/17 21:38:13 1.6
+++ cluster/gfs-kernel/src/gfs/eaops.c 2007/12/04 19:28:55 1.6.2.1
@@ -71,13 +71,6 @@
static int
user_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
- }
-
return gfs_ea_get_i(ip, er);
}
@@ -92,17 +85,6 @@
static int
user_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_set_i(ip, er);
}
@@ -117,17 +99,6 @@
static int
user_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_remove_i(ip, er);
}
@@ -238,11 +209,6 @@
static int
security_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
-
return gfs_ea_get_i(ip, er);
}
@@ -257,11 +223,6 @@
static int
security_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_set_i(ip, er);
}
@@ -276,11 +237,6 @@
static int
security_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_remove_i(ip, er);
}
@@ -312,4 +268,3 @@
&gfs_security_eaops,
};
-
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c
@ 2006-11-20 19:15 rohara
0 siblings, 0 replies; 4+ messages in thread
From: rohara @ 2006-11-20 19:15 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: rohara at sourceware.org 2006-11-20 19:15:49
Modified files:
gfs-kernel/src/gfs: eaops.c
Log message:
Fix comments to match function names.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/eaops.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.4&r2=1.1.2.5
--- cluster/gfs-kernel/src/gfs/eaops.c 2006/11/06 21:01:36 1.1.2.4
+++ cluster/gfs-kernel/src/gfs/eaops.c 2006/11/20 19:15:49 1.1.2.5
@@ -247,7 +247,7 @@
}
/**
- * system_eo_set -
+ * security_eo_set -
* @ip:
* @er:
*
@@ -266,7 +266,7 @@
}
/**
- * system_eo_remove -
+ * security_eo_remove -
* @ip:
* @er:
*
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-30 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-04 19:30 [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c rohara
-- strict thread matches above, loose matches on Subject: below --
2008-01-30 8:32 fabbione
2007-12-04 19:28 rohara
2006-11-20 19:15 rohara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.