All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed
@ 2008-02-07 10:57 Masakazu Mokuno
  2008-02-11 15:31 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Masakazu Mokuno @ 2008-02-07 10:57 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev, geoffrey.levand, Geert Uytterhoeven

PS3: gelic: Fix the wrong dev_id passed

The device id for lv1_net_set_interrupt_status_indicator() is wrong.
This path would be invoked only in the case of an initialization failure.

Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
---
 drivers/net/ps3_gelic_net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1512,7 +1512,7 @@ static int ps3_gelic_driver_probe (struc
 
 fail_setup_netdev:
 	lv1_net_set_interrupt_status_indicator(bus_id(card),
-					       bus_id(card),
+					       dev_id(card),
 					       0 , 0);
 fail_status_indicator:
 	ps3_dma_region_free(dev->d_region);



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed
  2008-02-07 10:57 [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed Masakazu Mokuno
@ 2008-02-11 15:31 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-02-11 15:31 UTC (permalink / raw)
  To: Masakazu Mokuno; +Cc: netdev, geoffrey.levand, Geert Uytterhoeven

Masakazu Mokuno wrote:
> PS3: gelic: Fix the wrong dev_id passed
> 
> The device id for lv1_net_set_interrupt_status_indicator() is wrong.
> This path would be invoked only in the case of an initialization failure.
> 
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> ---
>  drivers/net/ps3_gelic_net.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied 1-7

Please do not duplicate the email subject -- the change's one-line 
summary -- as the first line of the email.  I had to hand-edit each of 
this duplicate information out, before applying the patches.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-11 15:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-07 10:57 [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed Masakazu Mokuno
2008-02-11 15:31 ` Jeff Garzik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.