From: meyering@sourceware.org <meyering@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c
Date: 15 Feb 2008 14:12:34 -0000 [thread overview]
Message-ID: <20080215141234.32380.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: meyering at sourceware.org 2008-02-15 14:12:33
Modified files:
. : WHATS_NEW
daemons/clvmd : clvmd.c
Log message:
Remove redundant if-before-free tests in clvmd.c.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.794&r2=1.795
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.41&r2=1.42
--- LVM2/WHATS_NEW 2008/02/13 20:01:48 1.794
+++ LVM2/WHATS_NEW 2008/02/15 14:12:32 1.795
@@ -1,5 +1,6 @@
Version 2.02.34 -
===================================
+ Remove redundant if-before-free tests in clvmd.c.
Avoid a compiler warning: make is_orphan's parameter "const".
Fix lvconvert detection of mirror conversion in progress. (2.02.30)
Avoid automatic lvconvert polldaemon invocation when -R specified. (2.02.30)
--- LVM2/daemons/clvmd/clvmd.c 2008/02/05 09:38:04 1.41
+++ LVM2/daemons/clvmd/clvmd.c 2008/02/15 14:12:32 1.42
@@ -903,8 +903,7 @@
}
/* Free the command buffer */
- if (thisfd->bits.localsock.cmd)
- free(thisfd->bits.localsock.cmd);
+ free(thisfd->bits.localsock.cmd);
/* Clear out the cross-link */
if (thisfd->bits.localsock.pipe_client != NULL)
@@ -939,8 +938,7 @@
}
/* Free any old buffer space */
- if (thisfd->bits.localsock.cmd)
- free(thisfd->bits.localsock.cmd);
+ free(thisfd->bits.localsock.cmd);
/* See if we have the whole message */
argslen =
@@ -1547,8 +1545,7 @@
}
thisreply = thisreply->next;
- if (tempreply->replymsg)
- free(tempreply->replymsg);
+ free(tempreply->replymsg);
free(tempreply);
}
@@ -1579,8 +1576,7 @@
thisreply = thisreply->next;
- if (tempreply->replymsg)
- free(tempreply->replymsg);
+ free(tempreply->replymsg);
free(tempreply);
}
client->bits.localsock.replies = NULL;
@@ -1732,8 +1728,7 @@
pthread_mutex_unlock(&lvm_thread_mutex);
process_work_item(cmd);
- if (cmd->msg)
- free(cmd->msg);
+ free(cmd->msg);
free(cmd);
pthread_mutex_lock(&lvm_thread_mutex);
next reply other threads:[~2008-02-15 14:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 14:12 meyering [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 11:06 LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c zkabelac
2012-02-28 9:58 zkabelac
2012-02-28 9:53 zkabelac
2012-02-27 11:26 zkabelac
2012-02-27 9:58 zkabelac
2011-10-11 9:54 zkabelac
2011-10-11 9:26 zkabelac
2011-09-16 14:40 mbroz
2011-08-11 12:57 mbroz
2011-06-28 13:42 zkabelac
2011-03-30 12:36 zkabelac
2011-03-08 22:48 zkabelac
2011-03-08 13:27 mbroz
2010-12-13 10:49 prajnoha
2010-12-01 12:41 zkabelac
2010-12-01 10:46 zkabelac
2010-04-06 15:29 ccaulfield
2010-02-02 8:54 ccaulfield
2009-10-12 8:33 ccaulfield
2009-09-01 9:48 ccaulfield
2009-08-13 10:39 ccaulfield
2009-03-24 11:49 ccaulfield
2008-11-21 13:48 ccaulfield
2008-06-13 7:44 ccaulfield
2008-05-09 9:59 ccaulfield
2008-03-28 12:58 ccaulfield
2008-03-17 9:38 ccaulfield
2007-11-15 10:16 pcaulfield
2007-03-29 13:59 pcaulfield
2006-12-11 13:48 pcaulfield
2006-11-30 9:44 pcaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080215141234.32380.qmail@sourceware.org \
--to=meyering@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.