From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c
Date: 11 Aug 2011 12:57:11 -0000 [thread overview]
Message-ID: <20110811125711.31107.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2011-08-11 12:57:11
Modified files:
. : WHATS_NEW
daemons/clvmd : clvmd.c
Log message:
Never ever use uninitialised descriptors if pipe() fails
(because of maximum open count fd exceeded or so).
Better return busy message, so even clients fail in more controlled way.
Without patch, clvmd crashes with various strange backtraces
if under heavy load of connection requests.
https://bugzilla.redhat.com/show_bug.cgi?id=698393
https://bugzilla.redhat.com/show_bug.cgi?id=697945
(It still can OOM but that's different issue.)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2061&r2=1.2062
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.106&r2=1.107
--- LVM2/WHATS_NEW 2011/08/11 05:00:20 1.2061
+++ LVM2/WHATS_NEW 2011/08/11 12:57:10 1.2062
@@ -1,5 +1,6 @@
Version 2.02.87 -
===============================
+ If pipe in clvmd fails, return busy instead of using uninitialised descriptors.
Add dmeventd monitoring shared library for RAID.
Add RAID metadata devices to considered devices in _add_lv_to_dtree.
Fix renaming of RAID logical volumes.
--- LVM2/daemons/clvmd/clvmd.c 2011/08/09 18:11:00 1.106
+++ LVM2/daemons/clvmd/clvmd.c 2011/08/11 12:57:11 1.107
@@ -1263,9 +1263,19 @@
}
/* Create a pipe and add the reading end to our FD list */
- if (pipe(comms_pipe))
+ if (pipe(comms_pipe)) {
+ struct clvm_header reply;
DEBUGLOG("creating pipe failed: %s\n", strerror(errno));
-
+ reply.cmd = CLVMD_CMD_REPLY;
+ reply.status = EBUSY;
+ reply.arglen = 0;
+ reply.flags = 0;
+ send_message(&reply, sizeof(reply), our_csid,
+ thisfd->fd,
+ "Error sending EBUSY reply to local user");
+ return len;
+ }
+
newfd = malloc(sizeof(struct local_client));
if (!newfd) {
struct clvm_header reply;
next reply other threads:[~2011-08-11 12:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 12:57 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 11:06 LVM2 ./WHATS_NEW daemons/clvmd/clvmd.c zkabelac
2012-02-28 9:58 zkabelac
2012-02-28 9:53 zkabelac
2012-02-27 11:26 zkabelac
2012-02-27 9:58 zkabelac
2011-10-11 9:54 zkabelac
2011-10-11 9:26 zkabelac
2011-09-16 14:40 mbroz
2011-06-28 13:42 zkabelac
2011-03-30 12:36 zkabelac
2011-03-08 22:48 zkabelac
2011-03-08 13:27 mbroz
2010-12-13 10:49 prajnoha
2010-12-01 12:41 zkabelac
2010-12-01 10:46 zkabelac
2010-04-06 15:29 ccaulfield
2010-02-02 8:54 ccaulfield
2009-10-12 8:33 ccaulfield
2009-09-01 9:48 ccaulfield
2009-08-13 10:39 ccaulfield
2009-03-24 11:49 ccaulfield
2008-11-21 13:48 ccaulfield
2008-06-13 7:44 ccaulfield
2008-05-09 9:59 ccaulfield
2008-03-28 12:58 ccaulfield
2008-03-17 9:38 ccaulfield
2008-02-15 14:12 meyering
2007-11-15 10:16 pcaulfield
2007-03-29 13:59 pcaulfield
2006-12-11 13:48 pcaulfield
2006-11-30 9:44 pcaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811125711.31107.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.