All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP
@ 2008-06-17 11:53 Frans Pop
  2008-06-17 23:49 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Frans Pop @ 2008-06-17 11:53 UTC (permalink / raw)
  To: sparclinux

From: Frans Pop <elendil@planet.nl>

The module name was changed from esp to sun_esp some time ago.
    
Signed-off-by: Frans Pop <elendil@planet.nl>
---

Should the help text maybe also mention that it supports SUNW,fas devices?
It's still SBUS of course, but it may not be immediately obvious that esp 
also covers fas.


diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 81ccbd7..0632552 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1741,7 +1741,7 @@ config SCSI_SUNESP
 	  chipset is present in most SPARC SBUS-based computers.
 
 	  To compile this driver as a module, choose M here: the
-	  module will be called esp.
+	  module will be called sun_esp.
 
 config ZFCP
 	tristate "FCP host bus adapter driver for IBM eServer zSeries"

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] sparc: correct module name in Kconfig help for
  2008-06-17 11:53 [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
@ 2008-06-17 23:49 ` David Miller
  2008-06-18 16:14 ` [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
  2008-06-20  3:20 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-06-17 23:49 UTC (permalink / raw)
  To: sparclinux

From: Frans Pop <elendil@planet.nl>
Date: Tue, 17 Jun 2008 13:53:48 +0200

> The module name was changed from esp to sun_esp some time ago.
>     
> Signed-off-by: Frans Pop <elendil@planet.nl>

Applied, thank Frans.

> ---
> 
> Should the help text maybe also mention that it supports SUNW,fas devices?
> It's still SBUS of course, but it may not be immediately obvious that esp 
> also covers fas.

That might make the help text better, sure.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP
  2008-06-17 11:53 [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
  2008-06-17 23:49 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
@ 2008-06-18 16:14 ` Frans Pop
  2008-06-20  3:20 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Frans Pop @ 2008-06-18 16:14 UTC (permalink / raw)
  To: sparclinux

On Wednesday 18 June 2008, David Miller wrote:
> > Should the help text maybe also mention that it supports SUNW,fas
> > devices? It's still SBUS of course, but it may not be immediately
> > obvious that esp also covers fas.
>
> That might make the help text better, sure.

How about this:

 	   This is the driver for the Sun ESP SCSI host adapter. The ESP
-	   chipset is present in most SPARC SBUS-based computers.
+	   chipset is present in most SPARC SBUS-based computers and
+	   supports the Emulex family of ESP SCSI chips (esp100, esp100A,
+	   esp236, fas101, fas236) as well as the Qlogic fas366 SCSI chip.

Not sure if the chip details are correct, but I suspect you will :-)

If OK, would you prefer a separate patch for this or can you merge it into 
my previous patch?

Cheers,
FJP

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sparc: correct module name in Kconfig help for
  2008-06-17 11:53 [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
  2008-06-17 23:49 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
  2008-06-18 16:14 ` [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
@ 2008-06-20  3:20 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-06-20  3:20 UTC (permalink / raw)
  To: sparclinux

From: Frans Pop <elendil@planet.nl>
Date: Wed, 18 Jun 2008 18:14:25 +0200

> How about this:
> 
>  	   This is the driver for the Sun ESP SCSI host adapter. The ESP
> -	   chipset is present in most SPARC SBUS-based computers.
> +	   chipset is present in most SPARC SBUS-based computers and
> +	   supports the Emulex family of ESP SCSI chips (esp100, esp100A,
> +	   esp236, fas101, fas236) as well as the Qlogic fas366 SCSI chip.
> 
> Not sure if the chip details are correct, but I suspect you will :-)
> 
> If OK, would you prefer a separate patch for this or can you merge it into 
> my previous patch?

I merged it into your previous patch, thanks Frans.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-06-20  3:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-17 11:53 [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
2008-06-17 23:49 ` [PATCH] sparc: correct module name in Kconfig help for David Miller
2008-06-18 16:14 ` [PATCH] sparc: correct module name in Kconfig help for SCSI_SUNESP Frans Pop
2008-06-20  3:20 ` [PATCH] sparc: correct module name in Kconfig help for David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.