* [PATCH] udf: add llseek method
@ 2008-09-08 17:44 Christoph Hellwig
2008-09-08 18:35 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2008-09-08 17:44 UTC (permalink / raw)
To: jack, viro; +Cc: linux-fsdevel
UDF currently doesn't set a llseek method for regular files, which
means it will fall back to default_llseek. This means no one can seek
beyond 2 Gigabytes on reiserfs, and that there's not protection vs
the i_size updates from writers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/udf/file.c
===================================================================
--- linux-2.6.orig/fs/udf/file.c 2008-09-08 19:43:05.000000000 +0200
+++ linux-2.6/fs/udf/file.c 2008-09-08 19:43:18.000000000 +0200
@@ -211,6 +211,7 @@ const struct file_operations udf_file_op
.release = udf_release_file,
.fsync = udf_fsync_file,
.splice_read = generic_file_splice_read,
+ .llseek = generic_file_llseek,
};
const struct inode_operations udf_file_inode_operations = {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] udf: add llseek method
2008-09-08 17:44 [PATCH] udf: add llseek method Christoph Hellwig
@ 2008-09-08 18:35 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2008-09-08 18:35 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: viro, linux-fsdevel
On Mon 08-09-08 19:44:17, Christoph Hellwig wrote:
> UDF currently doesn't set a llseek method for regular files, which
> means it will fall back to default_llseek. This means no one can seek
> beyond 2 Gigabytes on reiserfs, and that there's not protection vs
> the i_size updates from writers.
Thanks. Merged after fixing typo in the changelog (reiserfs -> udf).
Honza
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/udf/file.c
> ===================================================================
> --- linux-2.6.orig/fs/udf/file.c 2008-09-08 19:43:05.000000000 +0200
> +++ linux-2.6/fs/udf/file.c 2008-09-08 19:43:18.000000000 +0200
> @@ -211,6 +211,7 @@ const struct file_operations udf_file_op
> .release = udf_release_file,
> .fsync = udf_fsync_file,
> .splice_read = generic_file_splice_read,
> + .llseek = generic_file_llseek,
> };
>
> const struct inode_operations udf_file_inode_operations = {
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-08 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-08 17:44 [PATCH] udf: add llseek method Christoph Hellwig
2008-09-08 18:35 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.