Re: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Fabio Comolli" <fabio.comolli@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	Jay Fenlason <fenlason@redhat.com>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Date: Mon, 24 Nov 2008 00:31:55 +0100	[thread overview]
Message-ID: <200811240031.55944.rjw@sisk.pl> (raw)
In-Reply-To: <b637ec0b0811231223r2032f221geeb19ea5804d3b91@mail.gmail.com>

On Sunday, 23 of November 2008, Fabio Comolli wrote:
> Hi.
> 
> On Sun, Nov 23, 2008 at 7:24 PM, Fabio Comolli <fabio.comolli@gmail.com> wrote:
> > Hi
> >
> > Yes. I started another bisection session between 2.6.27.4 and 2.6.27.5.
> >
> 
> Ok, this time things went much better. The bisection pointed to:
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------
> fcomolli@hawking:~/software/GIT-TREES/linux-2.6.27.y> git bisect good
> ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b is first bad commit
> commit ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b
> Author: Jay Fenlason <fenlason@redhat.com>
> Date:   Mon Oct 27 23:28:14 2008 +0100
> 
>     firewire: fix struct fw_node memory leak
> 
>     commit 77e557191701afa55ae7320d42ad6458a2ad292e upstream
> 
>     With the bus_resets patch applied, it is easy to see this memory leak
>     by repeatedly resetting the firewire bus while running slabtop in
>     another window.  Just watch kmalloc-32 grow and grow...
> 
>     Signed-off-by: Jay Fenlason <fenlason@redhat.com>
>     Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> 
> :040000 040000 01cadbd5f5fb81ce4f5e2023573204c4fbec3a28
> 809a53f4be87bd8be133ebd7564e1139a0cfa45b M      drivers
> ------------------------------------------------------------------------------------------------------------------------------------------------
> 
> And this is the log:
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------
> fcomolli@hawking:~/software/GIT-TREES/linux-2.6.27.y> git bisect log
> git-bisect start
> # good: [056c71459d3acf9fefcb2dc67abeef10e649d508] Linux 2.6.27.4
> git-bisect good 056c71459d3acf9fefcb2dc67abeef10e649d508
> # bad: [788a5f3f70e2a9c46020bdd3a195f2a866441c5d] Linux 2.6.27.5
> git-bisect bad 788a5f3f70e2a9c46020bdd3a195f2a866441c5d
> # bad: [7bdb542c453c14e54af9ebe5c4a827e4a678c47d] powerpc/numa: Make
> memory reserve code more robust
> git-bisect bad 7bdb542c453c14e54af9ebe5c4a827e4a678c47d
> # good: [f29062d0ec12ee3a58c67228dc829574b4ced378] syncookies: fix
> inclusion of tcp options in syn-ack
> git-bisect good f29062d0ec12ee3a58c67228dc829574b4ced378
> # good: [882491755d4c819de5bb593f04d06692185760aa] firewire: fix
> ioctl() return code
> git-bisect good 882491755d4c819de5bb593f04d06692185760aa
> # bad: [baae4f5fd7a75bdfa70d374b738963053df2bcaa] firewire: fw-sbp2: fix races
> git-bisect bad baae4f5fd7a75bdfa70d374b738963053df2bcaa
> # bad: [ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b] firewire: fix struct
> fw_node memory leak
> git-bisect bad ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b
> # good: [b6021579f54e5b6b31f03fe24de1208a2feb4aec] firewire: Survive
> more than 256 bus resets
> git-bisect good b6021579f54e5b6b31f03fe24de1208a2feb4aec
> ------------------------------------------------------------------------------------------------------------------------------------------------
> 
> The commit reverted cleanly and now I'm running 2.6.27.7 with that
> commit reverted. I'll post my results.
> 
> Hoper this helps. Regards,

Yes, thanks for bisecting this (CCs added).

Rafael