Re: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Fabio Comolli <fabio.comolli@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jay Fenlason <fenlason@redhat.com>
Subject: Re: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Date: Wed, 26 Nov 2008 02:03:02 +0100	[thread overview]
Message-ID: <492CA046.9010501@s5r6.in-berlin.de> (raw)
In-Reply-To: <200811260031.20079.rjw@sisk.pl>

Rafael J. Wysocki wrote:
>>>>> On Sun, Nov 23, 2008 at 7:24 PM, Fabio Comolli <fabio.comolli@gmail.com> wrote:
>>>>> The bisection pointed to:
>>>>>
>>>>> ------------------------------------------------------------------------------------------------------------------------------------------------
>>>>> fcomolli@hawking:~/software/GIT-TREES/linux-2.6.27.y> git bisect good
>>>>> ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b is first bad commit
>>>>> commit ff0f8d16839cd02dc95bd92c212cbd5d433a4d2b
>>>>> Author: Jay Fenlason <fenlason@redhat.com>
>>>>> Date:   Mon Oct 27 23:28:14 2008 +0100
>>>>>
>>>>>     firewire: fix struct fw_node memory leak
>>>>>
>>>>>     commit 77e557191701afa55ae7320d42ad6458a2ad292e upstream

(I still have a suspicion that this commit, or firewire even, is not the
actual culprit.  But one never knows.)

> Also, on a possibly related note, I've just found a report from a Mac Mini user
> who told me his machine hanged during resume from hibernation if his external
> firewire drive was connected to the port.  He worked around the problem by
> switching to the new firewire stack that worked for him.

The above bisection result is about the new stack = drivers/firewire/.
The old stack is drivers/ieee1394/ and I prefix all its changes with
"ieee1394:".

Of course the old stack is supposed to hibernate + restore properly too.
I personally tested only suspend + resume though, and that's quite long
ago...
-- 
Stefan Richter
-=====-==--- =-== ==-=-
http://arcgraph.de/sr/