* [PATCH] phylib: Remove unnecessary "reset" fixups in genphy_setup_forced
@ 2008-12-16 23:16 Andy Fleming
2008-12-16 23:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Fleming @ 2008-12-16 23:16 UTC (permalink / raw)
To: jeff; +Cc: netdev, Andy Fleming
genphy_setup_forced hasn't actually reset the PHY for a long time,
but a comment to that effect remained in the code, so code continued
to act as if it *had* reset the PHY, and called the necessary fixup
functions to respond to a PHY reset. With no reset, those functions
are no longer needed, so we remove them.
Signed-off-by: Andy Fleming <afleming@freescale.com>
---
drivers/net/phy/phy_device.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index e976c1c..b312d9c 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -508,23 +508,6 @@ int genphy_setup_forced(struct phy_device *phydev)
err = phy_write(phydev, MII_BMCR, ctl);
- if (err < 0)
- return err;
-
- /*
- * Run the fixups on this PHY, just in case the
- * board code needs to change something after a reset
- */
- err = phy_scan_fixups(phydev);
-
- if (err < 0)
- return err;
-
- /* We just reset the device, so we'd better configure any
- * settings the PHY requires to operate */
- if (phydev->drv->config_init)
- err = phydev->drv->config_init(phydev);
-
return err;
}
--
1.5.4.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phylib: Remove unnecessary "reset" fixups in genphy_setup_forced
2008-12-16 23:16 [PATCH] phylib: Remove unnecessary "reset" fixups in genphy_setup_forced Andy Fleming
@ 2008-12-16 23:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-16 23:39 UTC (permalink / raw)
To: afleming; +Cc: jeff, netdev
From: Andy Fleming <afleming@freescale.com>
Date: Tue, 16 Dec 2008 17:16:29 -0600
> genphy_setup_forced hasn't actually reset the PHY for a long time,
> but a comment to that effect remained in the code, so code continued
> to act as if it *had* reset the PHY, and called the necessary fixup
> functions to respond to a PHY reset. With no reset, those functions
> are no longer needed, so we remove them.
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-16 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-16 23:16 [PATCH] phylib: Remove unnecessary "reset" fixups in genphy_setup_forced Andy Fleming
2008-12-16 23:39 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.